diff mbox series

[v2,3/3] oe-selftest: add test for useradd with only USERADD_DEPENDS

Message ID 20260420163940.182918-4-zizuzacker@gmail.com
State Under Review
Headers show
Series useradd.bbclass: fix parse error when only USERADD_DEPENDS is set | expand

Commit Message

Zk47T April 20, 2026, 4:39 p.m. UTC
Add a test case to verify that a recipe inheriting useradd with only
USERADD_DEPENDS set (and no USERADD_PACKAGES) parses and builds
successfully. This validates the fix in useradd.bbclass for
[YOCTO #15863].

Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
---
 meta/lib/oeqa/selftest/cases/usergrouptests.py | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Mathieu Dubois-Briand April 23, 2026, 6:44 a.m. UTC | #1
On Mon Apr 20, 2026 at 6:39 PM CEST, Zk47T via lists.openembedded.org wrote:
> Add a test case to verify that a recipe inheriting useradd with only
> USERADD_DEPENDS set (and no USERADD_PACKAGES) parses and builds
> successfully. This validates the fix in useradd.bbclass for
> [YOCTO #15863].
>
> Signed-off-by: Nguyen Minh Tien <zizuzacker@gmail.com>
> ---
>  meta/lib/oeqa/selftest/cases/usergrouptests.py | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meta/lib/oeqa/selftest/cases/usergrouptests.py b/meta/lib/oeqa/selftest/cases/usergrouptests.py
> index 3c59b0f290..69025a59aa 100644
> --- a/meta/lib/oeqa/selftest/cases/usergrouptests.py
> +++ b/meta/lib/oeqa/selftest/cases/usergrouptests.py
> @@ -55,3 +55,9 @@ class UserGroupTests(OESelftestTestCase):
>          self.write_config("USERADD_GID_TABLES += \"files/static-group\"")
>          self.logger.info("Rebuild with other staticids")
>          self.assertTrue(bitbake(' core-image-minimal'))
> +
> +    def test_useradd_depends_only(self):
> +        # Test that a recipe inheriting useradd with only USERADD_DEPENDS
> +        # (and no USERADD_PACKAGES) parses and builds successfully. [YOCTO #15863]
> +        self.logger.info("Building usegroup-deponly to test USERADD_DEPENDS only")
> +        self.assertTrue(bitbake(' usegroup-deponly'))


Hi,

Thanks for adding tests.

Yet, it looks like this test is always failing. I had the issue both on
the autobuilder and locally:

2026-04-22 13:30:16,318 - oe-selftest - INFO - usergrouptests.UserGroupTests.test_useradd_depends_only (subunit.RemotedTestCase)
2026-04-22 13:30:16,332 - oe-selftest - INFO -  ... FAIL
...
ERROR: usegroup-deponly-1.0-r0 do_unpack: S should be set relative to UNPACKDIR, e.g. replace WORKDIR with UNPACKDIR in "S = ${WORKDIR}/sources"
ERROR: Logfile of failure stored in: /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-409425/tmp/work/all-poky-linux/usegroup-deponly/1.0/temp/log.do_unpack.2060861
NOTE: recipe usegroup-deponly-1.0-r0: task do_unpack: Failed
ERROR: Task (/srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-409425/meta-selftest/recipes-test/selftest-users/usegroup-deponly.bb:do_unpack) failed with exit code '1'

https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/3719
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/3606

So I believe the issue does not code from the test, but from the recipe
itself.

Can you have a look at the issue?

Thanks,
Mathieu
diff mbox series

Patch

diff --git a/meta/lib/oeqa/selftest/cases/usergrouptests.py b/meta/lib/oeqa/selftest/cases/usergrouptests.py
index 3c59b0f290..69025a59aa 100644
--- a/meta/lib/oeqa/selftest/cases/usergrouptests.py
+++ b/meta/lib/oeqa/selftest/cases/usergrouptests.py
@@ -55,3 +55,9 @@  class UserGroupTests(OESelftestTestCase):
         self.write_config("USERADD_GID_TABLES += \"files/static-group\"")
         self.logger.info("Rebuild with other staticids")
         self.assertTrue(bitbake(' core-image-minimal'))
+
+    def test_useradd_depends_only(self):
+        # Test that a recipe inheriting useradd with only USERADD_DEPENDS
+        # (and no USERADD_PACKAGES) parses and builds successfully. [YOCTO #15863]
+        self.logger.info("Building usegroup-deponly to test USERADD_DEPENDS only")
+        self.assertTrue(bitbake(' usegroup-deponly'))