diff mbox series

apr-utils: Fix old style function prototype warning with clang

Message ID 20260408023246.297244-1-khem.raj@oss.qualcomm.com
State Under Review
Headers show
Series apr-utils: Fix old style function prototype warning with clang | expand

Commit Message

Khem Raj April 8, 2026, 2:32 a.m. UTC 
Fixes build with autoconf-2.73 + clang-22

Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...le-function-prototype-warning-with-c.patch | 130 ++++++++++++++++++
 meta/recipes-support/apr/apr-util_1.6.3.bb    |   1 +
 2 files changed, 131 insertions(+)
 create mode 100644 meta/recipes-support/apr/apr-util/0001-sdbm-Fix-old-style-function-prototype-warning-with-c.patch
diff mbox series

Patch

diff --git a/meta/recipes-support/apr/apr-util/0001-sdbm-Fix-old-style-function-prototype-warning-with-c.patch b/meta/recipes-support/apr/apr-util/0001-sdbm-Fix-old-style-function-prototype-warning-with-c.patch
new file mode 100644
index 0000000000..e523859927
--- /dev/null
+++ b/meta/recipes-support/apr/apr-util/0001-sdbm-Fix-old-style-function-prototype-warning-with-c.patch
@@ -0,0 +1,130 @@ 
+From 05afaf207eaff4c175198abd129ed1acde220df3 Mon Sep 17 00:00:00 2001
+From: Yann Ylavic <ylavic@apache.org>
+Date: Thu, 14 Mar 2024 15:52:25 +0000
+Subject: [PATCH] sdbm: Fix old style function prototype warning with clang
+
+This fixes the following warning with clang
+
+../dbm/sdbm/sdbm_pair.c:63:1: warning: a function definition without a prototype is
+deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
+   63 | fitpair(pag, need)
+      | ^
+
+Upstream-Status: Backport [https://github.com/apache/apr-util/commit/073368a46fbe92995927258ae2fc97d3920872f2]
+Signed-off-by: Biswapriyo Nath <nathbappai@gmail.com>
+Submitted by: Biswapriyo Nath <nathbappai@gmail.com>
+Github: closes #47
+
+Merges r1912679 from ^/apr/apr/trunk
+
+git-svn-id: https://svn.apache.org/repos/asf/apr/apr-util/branches/1.7.x@1916307 13f79535-47bb-0310-9956-ffa450edef68
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+ dbm/sdbm/sdbm_pair.c | 39 +++++++++------------------------------
+ 1 file changed, 9 insertions(+), 30 deletions(-)
+
+diff --git a/dbm/sdbm/sdbm_pair.c b/dbm/sdbm/sdbm_pair.c
+index 50d7965..6ecaff6 100644
+--- a/dbm/sdbm/sdbm_pair.c
++++ b/dbm/sdbm/sdbm_pair.c
+@@ -60,9 +60,7 @@ static int seepair(char *, int, char *, int);
+  */
+ 
+ int
+-fitpair(pag, need)
+-char *pag;
+-int need;
++fitpair(char *pag, int need)
+ {
+ 	register int n;
+ 	register int off;
+@@ -79,10 +77,7 @@ int need;
+ }
+ 
+ void
+-putpair(pag, key, val)
+-char *pag;
+-apr_sdbm_datum_t key;
+-apr_sdbm_datum_t val;
++putpair(char *pag, apr_sdbm_datum_t key, apr_sdbm_datum_t val)
+ {
+ 	register int n;
+ 	register int off;
+@@ -108,9 +103,7 @@ apr_sdbm_datum_t val;
+ }
+ 
+ apr_sdbm_datum_t
+-getpair(pag, key)
+-char *pag;
+-apr_sdbm_datum_t key;
++getpair(char *pag, apr_sdbm_datum_t key)
+ {
+ 	register int i;
+ 	register int n;
+@@ -129,18 +122,14 @@ apr_sdbm_datum_t key;
+ }
+ 
+ int
+-duppair(pag, key)
+-char *pag;
+-apr_sdbm_datum_t key;
++duppair(char *pag, apr_sdbm_datum_t key)
+ {
+ 	register short *ino = (short *) pag;
+ 	return ino[0] > 0 && seepair(pag, ino[0], key.dptr, key.dsize) > 0;
+ }
+ 
+ apr_sdbm_datum_t
+-getnkey(pag, num)
+-char *pag;
+-int num;
++getnkey(char *pag, int num)
+ {
+ 	apr_sdbm_datum_t key;
+ 	register int off;
+@@ -159,9 +148,7 @@ int num;
+ }
+ 
+ int
+-delpair(pag, key)
+-char *pag;
+-apr_sdbm_datum_t key;
++delpair(char *pag, apr_sdbm_datum_t key)
+ {
+ 	register int n;
+ 	register int i;
+@@ -231,11 +218,7 @@ apr_sdbm_datum_t key;
+  * return 0 if not found.
+  */
+ static int
+-seepair(pag, n, key, siz)
+-char *pag;
+-register int n;
+-register char *key;
+-register int siz;
++seepair(char *pag, register int n, register char *key, register int siz)
+ {
+ 	register int i;
+ 	register int off = PBLKSIZ;
+@@ -251,10 +234,7 @@ register int siz;
+ }
+ 
+ void
+-splpage(pag, new, sbit)
+-char *pag;
+-char *new;
+-long sbit;
++splpage(char *pag, char *new, long sbit)
+ {
+ 	apr_sdbm_datum_t key;
+ 	apr_sdbm_datum_t val;
+@@ -295,8 +275,7 @@ long sbit;
+  * this could be made more rigorous.
+  */
+ int
+-chkpage(pag)
+-char *pag;
++chkpage(char *pag)
+ {
+ 	register int n;
+ 	register int off;
diff --git a/meta/recipes-support/apr/apr-util_1.6.3.bb b/meta/recipes-support/apr/apr-util_1.6.3.bb
index b5e3d2fc8a..17dc79cc9a 100644
--- a/meta/recipes-support/apr/apr-util_1.6.3.bb
+++ b/meta/recipes-support/apr/apr-util_1.6.3.bb
@@ -12,6 +12,7 @@  LIC_FILES_CHKSUM = "file://LICENSE;md5=158aa0b1efe0c12f23d4b007ddb9a5db \
 SRC_URI = "${APACHE_MIRROR}/apr/${BPN}-${PV}.tar.gz \
            file://configfix.patch \
 	   file://0001-test_transformation-Check-if-transform-is-supported-.patch \
+	       file://0001-sdbm-Fix-old-style-function-prototype-warning-with-c.patch \
            file://run-ptest \
            "