| Message ID | 20260402073331.2436504-1-pavel@loebl.cz |
|---|---|
| State | New |
| Headers | show |
| Series | uki.bbclass: fix ukify arguments assembly | expand |
Hi, On Thu, Apr 02, 2026 at 09:33:15AM +0200, Pavel L�bl wrote: > Missing space before --uname ukify option mangles the command line > string when KERNEL_VERSION is set. Thanks, this is a clear bug. meta/lib/oeqa/selftest/cases/uki.py could be improved to cover this. I would be interested to know if the kernel version autodetection does not work since that is preferred by ukify.py and this KERNEL_VERSION handling in uki.bbclass could be removed. Reviewed-by: Mikko Rapeli <mikko.rapeli@linaro.org> Cheers, -Mikko > Signed-off-by: Pavel L�bl <pavel@loebl.cz> > --- > meta/classes-recipe/uki.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/uki.bbclass b/meta/classes-recipe/uki.bbclass > index 326697a06660..a89e92b77869 100644 > --- a/meta/classes-recipe/uki.bbclass > +++ b/meta/classes-recipe/uki.bbclass > @@ -140,7 +140,7 @@ python do_uki() { > # not always needed, ukify can detect version from kernel binary > kernel_version = d.getVar('KERNEL_VERSION') > if kernel_version: > - ukify_cmd += "--uname %s" % (kernel_version) > + ukify_cmd += " --uname %s" % (kernel_version) > else: > bb.fatal("ERROR - UKI_KERNEL_FILENAME not set") > > -- > 2.53.0 >
diff --git a/meta/classes-recipe/uki.bbclass b/meta/classes-recipe/uki.bbclass index 326697a06660..a89e92b77869 100644 --- a/meta/classes-recipe/uki.bbclass +++ b/meta/classes-recipe/uki.bbclass @@ -140,7 +140,7 @@ python do_uki() { # not always needed, ukify can detect version from kernel binary kernel_version = d.getVar('KERNEL_VERSION') if kernel_version: - ukify_cmd += "--uname %s" % (kernel_version) + ukify_cmd += " --uname %s" % (kernel_version) else: bb.fatal("ERROR - UKI_KERNEL_FILENAME not set")
Missing space before --uname ukify option mangles the command line string when KERNEL_VERSION is set. Signed-off-by: Pavel Löbl <pavel@loebl.cz> --- meta/classes-recipe/uki.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)