| Message ID | 20260326125113.1853869-14-zboszor@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [01/13] python3: Add warning comment before PACKAGECONFIG[freethreading] | expand |
On Thu, 26 Mar 2026 at 13:51, Zoltan Boszormenyi via lists.openembedded.org <zboszor=gmail.com@lists.openembedded.org> wrote: > Instead of open coding, use python3native and xcb-proto-native > as an extra build dependency. > -DEPENDS = "xcb-proto xorgproto libxau libpthread-stubs libxdmcp" > +DEPENDS = "xcb-proto-native xcb-proto xorgproto libxau libpthread-stubs libxdmcp" This change isn't explained. > -inherit autotools pkgconfig features_check > +inherit autotools pkgconfig python3native features_check > -export PYTHON = "python3" I'm not sure this is an improvement? We try to avoid using native python whenever possible, and use python from the host if it doesn't cause issues. The rest of the patchset looks okay on first glance, but it does include a breaking change, and you need to at least try to fix meta-oe (or ensure nothing breaks in there which is unlikely). Alex
2026. 03. 26. 14:06 keltezéssel, Alexander Kanavin írta: > On Thu, 26 Mar 2026 at 13:51, Zoltan Boszormenyi via > lists.openembedded.org <zboszor=gmail.com@lists.openembedded.org> > wrote: >> Instead of open coding, use python3native and xcb-proto-native >> as an extra build dependency. >> -DEPENDS = "xcb-proto xorgproto libxau libpthread-stubs libxdmcp" >> +DEPENDS = "xcb-proto-native xcb-proto xorgproto libxau libpthread-stubs libxdmcp" > This change isn't explained. I will move this commit to the free-threading enablement RFC series and add the explanation to the commit message. The problem is that the build failed with ModuleNotFoundError for xcbgen when free-threading was enabled. No idea how this is satisfied without the xcb-proto installed on the host. >> -inherit autotools pkgconfig features_check >> +inherit autotools pkgconfig python3native features_check >> -export PYTHON = "python3" > I'm not sure this is an improvement? We try to avoid using native > python whenever possible, and use python from the host if it doesn't > cause issues. > > The rest of the patchset looks okay on first glance, but it does > include a breaking change, and you need to at least try to fix meta-oe > (or ensure nothing breaks in there which is unlikely). > > Alex
2026. 03. 26. 14:26 keltezéssel, Zoltan Boszormenyi via lists.openembedded.org írta: > 2026. 03. 26. 14:06 keltezéssel, Alexander Kanavin írta: >> On Thu, 26 Mar 2026 at 13:51, Zoltan Boszormenyi via >> lists.openembedded.org <zboszor=gmail.com@lists.openembedded.org> >> wrote: >>> Instead of open coding, use python3native and xcb-proto-native >>> as an extra build dependency. >>> -DEPENDS = "xcb-proto xorgproto libxau libpthread-stubs libxdmcp" >>> +DEPENDS = "xcb-proto-native xcb-proto xorgproto libxau libpthread-stubs libxdmcp" >> This change isn't explained. > > I will move this commit to the free-threading enablement RFC series and > add the explanation to the commit message. > > The problem is that the build failed with ModuleNotFoundError > for xcbgen when free-threading was enabled. > No idea how this is satisfied without the xcb-proto installed on the host. Now I know. This change won't be necessary, but another tweak for xcb-proto will be. The xcb-proto.pc must be generated correctly with the ABI flag. >>> -inherit autotools pkgconfig features_check >>> +inherit autotools pkgconfig python3native features_check >>> -export PYTHON = "python3" >> I'm not sure this is an improvement? We try to avoid using native >> python whenever possible, and use python from the host if it doesn't >> cause issues. >> >> The rest of the patchset looks okay on first glance, but it does >> include a breaking change, and you need to at least try to fix meta-oe >> (or ensure nothing breaks in there which is unlikely). >> >> Alex > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#234001): https://lists.openembedded.org/g/openembedded-core/message/234001 > Mute This Topic: https://lists.openembedded.org/mt/118517418/3617728 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [zboszor@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/recipes-graphics/xorg-lib/libxcb_1.17.0.bb b/meta/recipes-graphics/xorg-lib/libxcb_1.17.0.bb index fcd8aad303..ac2fcd4cc8 100644 --- a/meta/recipes-graphics/xorg-lib/libxcb_1.17.0.bb +++ b/meta/recipes-graphics/xorg-lib/libxcb_1.17.0.bb @@ -16,19 +16,17 @@ SRC_URI[sha256sum] = "599ebf9996710fea71622e6e184f3a8ad5b43d0e5fa8c4e407123c88a5 BBCLASSEXTEND = "native nativesdk" -DEPENDS = "xcb-proto xorgproto libxau libpthread-stubs libxdmcp" +DEPENDS = "xcb-proto-native xcb-proto xorgproto libxau libpthread-stubs libxdmcp" PACKAGES_DYNAMIC = "^${PN}-.*" FILES:${PN} = "${libdir}/libxcb.so.*" -inherit autotools pkgconfig features_check +inherit autotools pkgconfig python3native features_check # The libxau and others requires x11 in DISTRO_FEATURES REQUIRED_DISTRO_FEATURES = "x11" -export PYTHON = "python3" - do_install:append () { chown root.root ${D}${datadir}/doc/${BPN}/tutorial -R }
Instead of open coding, use python3native and xcb-proto-native as an extra build dependency. Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> --- meta/recipes-graphics/xorg-lib/libxcb_1.17.0.bb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)