diff mbox series

fixup! runqemu: restore support to run inside SDK

Message ID 20260319043625.3641522-1-Qi.Chen@windriver.com
State Changes Requested
Headers show
Series fixup! runqemu: restore support to run inside SDK | expand

Commit Message

Chen, Qi March 19, 2026, 4:36 a.m. UTC
From: Chen Qi <Qi.Chen@windriver.com>

In previous patch[1], the os.path.exists was accidently called twice.
This is incorrect.

[1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 scripts/runqemu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Barker March 19, 2026, 11:38 a.m. UTC | #1
On Wed, 2026-03-18 at 21:36 -0700, Chen Qi via lists.openembedded.org
wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> In previous patch[1], the os.path.exists was accidently called twice.
> This is incorrect.
> 
> [1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  scripts/runqemu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 5587d47865..d84c6fdc1e 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -1005,7 +1005,7 @@ to your build configuration.
>          # If the STAGING_BINDIR_NATIVE directories from the config file don't exist
>          # and we're in a sourced OE build directory try to extract the paths
>          # from `bitbake -e`
> -        havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE')))
> +        havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
>  
>          if not havenative:
>              if not self.bitbake_e:

Hi,

The commit title contains "fixup!", please could you re-send with a
proper title for this patch?

Best regards,
diff mbox series

Patch

diff --git a/scripts/runqemu b/scripts/runqemu
index 5587d47865..d84c6fdc1e 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1005,7 +1005,7 @@  to your build configuration.
         # If the STAGING_BINDIR_NATIVE directories from the config file don't exist
         # and we're in a sourced OE build directory try to extract the paths
         # from `bitbake -e`
-        havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE')))
+        havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
 
         if not havenative:
             if not self.bitbake_e: