[08/12] initscripts: Make SRC_URI arch independent

Message ID	20260318-fix-checklayer-2-v1-8-388ba6ce47cd@pbarker.dev
State	New
Headers	show Return-Path: <paul@pbarker.dev> ip: 103.168.172.158, mailfrom: paul@pbarker.dev) Feedback-ID: i51494658:Fastmail From: Paul Barker <paul@pbarker.dev> Date: Wed, 18 Mar 2026 17:14:51 +0000 Subject: [PATCH 08/12] initscripts: Make SRC_URI arch independent MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260318-fix-checklayer-2-v1-8-388ba6ce47cd@pbarker.dev> References: <20260318-fix-checklayer-2-v1-0-388ba6ce47cd@pbarker.dev> In-Reply-To: <20260318-fix-checklayer-2-v1-0-388ba6ce47cd@pbarker.dev> To: openembedded-core@lists.openembedded.org Cc: Paul Barker <paul@pbarker.dev>
Series	Further check-layer fixes \| expand [00/12] Further check-layer fixes [01/12] checklayer: Fix regex in get_signatures [02/12] curl: Drop arch dependent search paths [03/12] ghostscript: Drop arch dependent search paths [04/12] libssh2: Drop arch dependent search paths [05/12] flac: Use arch independent search path [06/12] gettext: Use arch independent search paths [07/12] gnutls: Use arch independent search paths [08/12] initscripts: Make SRC_URI arch independent [09/12] linux-yocto: Avoid arch dependent vardeps for SRC_URI [10/12] libsdl2: Explicitly set PACKAGECONFIG vardeps [11/12] graphene: Explicitly set PACKAGECONFIG vardeps [12/12] gstreamer1.0-plugins-good: Explicitly set PACKAGECONFIG vardeps

Message ID

20260318-fix-checklayer-2-v1-8-388ba6ce47cd@pbarker.dev

State

New

Headers

Feedback-ID: i51494658:Fastmail
From: Paul Barker <paul@pbarker.dev>
Date: Wed, 18 Mar 2026 17:14:51 +0000
Subject: [PATCH 08/12] initscripts: Make SRC_URI arch independent
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20260318-fix-checklayer-2-v1-8-388ba6ce47cd@pbarker.dev>
References: <20260318-fix-checklayer-2-v1-0-388ba6ce47cd@pbarker.dev>
In-Reply-To: <20260318-fix-checklayer-2-v1-0-388ba6ce47cd@pbarker.dev>
To: openembedded-core@lists.openembedded.org
Cc: Paul Barker <paul@pbarker.dev>

Series

Further check-layer fixes | expand

Avoid making SRC_URI unnecessarily dependent on the target architecture. Signed-off-by: Paul Barker <paul@pbarker.dev> --- meta/recipes-core/initscripts/initscripts_1.0.bb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Richard Purdie March 18, 2026, 5:22 p.m. UTC | #1

On Wed, 2026-03-18 at 17:14 +0000, Paul Barker via lists.openembedded.org wrote:
> Avoid making SRC_URI unnecessarily dependent on the target architecture.
> 
> Signed-off-by: Paul Barker <paul@pbarker.dev>
> ---
>  meta/recipes-core/initscripts/initscripts_1.0.bb | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
> index c984257c5c8f..23411b6a7149 100644
> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
> @@ -32,14 +32,12 @@ SRC_URI = "file://functions \
>             file://save-rtc.sh \
>             file://dmesg.sh \
>             file://logrotate-dmesg.conf \
> +           file://alignment.sh \
>             ${@bb.utils.contains('DISTRO_FEATURES','selinux','file://sushell','',d)} \
>  "
>  
>  S = "${UNPACKDIR}"
>  
> -SRC_URI:append:arm = " file://alignment.sh"
> -SRC_URI:append:armeb = " file://alignment.sh"
> -
> 


alignment.sh is pointless outside of arm. The commit message needs to
mention that the installation of it is still conditional on the arm
arch.

Cheers,

Richard

diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
index c984257c5c8f..23411b6a7149 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -32,14 +32,12 @@  SRC_URI = "file://functions \
            file://save-rtc.sh \
            file://dmesg.sh \
            file://logrotate-dmesg.conf \
+           file://alignment.sh \
            ${@bb.utils.contains('DISTRO_FEATURES','selinux','file://sushell','',d)} \
 "
 
 S = "${UNPACKDIR}"
 
-SRC_URI:append:arm = " file://alignment.sh"
-SRC_URI:append:armeb = " file://alignment.sh"
-
 KERNEL_VERSION = ""
 
 DEPENDS:append = " update-rc.d-native"

[08/12] initscripts: Make SRC_URI arch independent

Commit Message

Comments

Patch