| Message ID | 20260318-fix-checklayer-2-v1-10-388ba6ce47cd@pbarker.dev |
|---|---|
| State | New |
| Headers | show |
| Series | Further check-layer fixes | expand |
On Wed, 2026-03-18 at 17:14 +0000, Paul Barker via lists.openembedded.org wrote: > The variable dependencies are discarded for PACKAGECONFIG, which may > cause tasks which use the value of PACKAGECONFIG to be considered > arch-independent, even when the value is actually different depending on > the target architecture. > > In this case, we use the value of TUNE_FEATURES in PACKAGECONFIG, which > is obviously arch-dependent so we should explicitly list this > dependency. > > Signed-off-by: Paul Barker <paul@pbarker.dev> > --- > meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb > index 834cf096b977..f7c292b6adb0 100644 > --- a/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb > +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb > @@ -80,6 +80,9 @@ PACKAGECONFIG[vulkan] = "-DSDL_VULKAN=ON,-DSDL_VULKAN=OFF" > PACKAGECONFIG[wayland] = "-DSDL_WAYLAND=ON,-DSDL_WAYLAND=OFF,wayland-native wayland wayland-protocols libxkbcommon" > PACKAGECONFIG[x11] = "-DSDL_X11=ON,-DSDL_X11=OFF,virtual/libx11 libxext libxrandr libxrender" > > +# PACKAGECONFIG dependencies are not automatically carried forwards > +PACKAGECONFIG[vardeps] += "TUNE_FEATURES" I'm not understanding the issue here. I added a vardepvalue for PACKAGECONFIG but the usage of TUNE_FEATURES here shouldn't matter, the expanded value will differ and that should be all we need for the taskhashes to work properly. What issue are you trying to solve here? Cheers, Richard
diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb index 834cf096b977..f7c292b6adb0 100644 --- a/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb @@ -80,6 +80,9 @@ PACKAGECONFIG[vulkan] = "-DSDL_VULKAN=ON,-DSDL_VULKAN=OFF" PACKAGECONFIG[wayland] = "-DSDL_WAYLAND=ON,-DSDL_WAYLAND=OFF,wayland-native wayland wayland-protocols libxkbcommon" PACKAGECONFIG[x11] = "-DSDL_X11=ON,-DSDL_X11=OFF,virtual/libx11 libxext libxrandr libxrender" +# PACKAGECONFIG dependencies are not automatically carried forwards +PACKAGECONFIG[vardeps] += "TUNE_FEATURES" + CFLAGS:append:class-native = " -DNO_SHARED_MEMORY" FILES:${PN} += "${datadir}/licenses/SDL2/LICENSE.txt"
The variable dependencies are discarded for PACKAGECONFIG, which may cause tasks which use the value of PACKAGECONFIG to be considered arch-independent, even when the value is actually different depending on the target architecture. In this case, we use the value of TUNE_FEATURES in PACKAGECONFIG, which is obviously arch-dependent so we should explicitly list this dependency. Signed-off-by: Paul Barker <paul@pbarker.dev> --- meta/recipes-graphics/libsdl2/libsdl2_2.32.10.bb | 3 +++ 1 file changed, 3 insertions(+)