[v3,03/13] expat: Convert confusing append to assignment

Message ID	20260317-fix-invalid-appends-v3-3-59452f073f31@gmail.com
State	New
Headers	show Return-Path: <michalwsieron@gmail.com> ip: 209.85.208.47, mailfrom: michalwsieron@gmail.com) From: Michal Sieron <michalwsieron@gmail.com> Date: Tue, 17 Mar 2026 21:29:02 +0100 Subject: [PATCH v3 03/13] expat: Convert confusing append to assignment MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260317-fix-invalid-appends-v3-3-59452f073f31@gmail.com> References: <20260317-fix-invalid-appends-v3-0-59452f073f31@gmail.com> In-Reply-To: <20260317-fix-invalid-appends-v3-0-59452f073f31@gmail.com> To: openembedded-core@lists.openembedded.org Cc: Michal Sieron <michalwsieron@gmail.com>
Series	Confusing and invalid conditional appends \| expand [v3,00/13] Confusing and invalid conditional appends [v3,01/13] libffi: Convert confusing append to assignment [v3,02/13] coreutils: Convert confusing append to override syntax [v3,03/13] expat: Convert confusing append to assignment [v3,04/13] tune-power[567]: Remove confusing overrides [v3,05/13] no-gplv3.inc: Convert confusing appends to override syntax [v3,06/13] bootchart2: Convert confusing appends to override syntax [v3,07/13] pigz: Convert confusing append to override syntax [v3,08/13] systemtap: Convert confusing append to override syntax [v3,09/13] ovmf: Convert confusing append to override syntax [v3,10/13] dnf: Convert confusing append to override syntax [v3,11/13] qemu: Convert confusing append to override syntax [v3,12/13] recipes-devtools/python: Convert confusing appends to override syntax [v3,13/13] musl-locales: Fix locale-base-sr-sr typo

Message ID

20260317-fix-invalid-appends-v3-3-59452f073f31@gmail.com

State

New

Headers

From: Michal Sieron <michalwsieron@gmail.com>
Date: Tue, 17 Mar 2026 21:29:02 +0100
Subject: [PATCH v3 03/13] expat: Convert confusing append to assignment
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20260317-fix-invalid-appends-v3-3-59452f073f31@gmail.com>
References: <20260317-fix-invalid-appends-v3-0-59452f073f31@gmail.com>
In-Reply-To: <20260317-fix-invalid-appends-v3-0-59452f073f31@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Michal Sieron <michalwsieron@gmail.com>

Series

Confusing and invalid conditional appends | expand

Commit Message

Michal Sieron March 17, 2026, 8:29 p.m. UTC

This is the only assignment to EXTRA_OECMAKE in this recipe, so using
`+=`, especially to a variable with an override can be confusing. Let's
avoid that and use explicit assignment.

Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
---
 meta/recipes-core/expat/expat_2.7.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/expat/expat_2.7.4.bb b/meta/recipes-core/expat/expat_2.7.4.bb
index 95a1ed52c4..a464f7c703 100644
--- a/meta/recipes-core/expat/expat_2.7.4.bb
+++ b/meta/recipes-core/expat/expat_2.7.4.bb
@@ -17,7 +17,7 @@  UPSTREAM_CHECK_REGEX = "releases/tag/R_(?P<pver>.+)"
 
 SRC_URI[sha256sum] = "e6af11b01e32e5ef64906a5cca8809eabc4beb7ff2f9a0e6aabbd42e825135d0"
 
-EXTRA_OECMAKE:class-native += "-DEXPAT_BUILD_DOCS=OFF"
+EXTRA_OECMAKE:class-native = "-DEXPAT_BUILD_DOCS=OFF"
 
 RDEPENDS:${PN}-ptest += "bash"

[v3,03/13] expat: Convert confusing append to assignment

Commit Message

Patch