| Message ID | 20260203143434.3117764-1-samuli.piippo@qt.io |
|---|---|
| State | New |
| Headers | show |
| Series | oe/utils: filter license packages | expand |
On Tue, 3 Feb 2026 at 15:34, Samuli Piippo via lists.openembedded.org <samuli.piippo=gmail.com@lists.openembedded.org> wrote: > Make packages_filter_out_system() filter out also the > license (-lic) packages. Why? What does the function do, and where is it used? Yes, it's possible to spend time, read the code, and find the answers, but you would really help the review by writing those things into the commit message. Alex
The function is used at least in PACKAGESPLITFUNCS to filter out all the system packages and then settings rdepends/recommends/etc for the remaining dynamic packages. Without this commit, the *-lic license package gets pulled in unintentionally. -samuli On Tue, 3 Feb 2026 at 18:25, Alexander Kanavin <alex.kanavin@gmail.com> wrote: > On Tue, 3 Feb 2026 at 15:34, Samuli Piippo via lists.openembedded.org > <samuli.piippo=gmail.com@lists.openembedded.org> wrote: > > Make packages_filter_out_system() filter out also the > > license (-lic) packages. > > Why? What does the function do, and where is it used? > > Yes, it's possible to spend time, read the code, and find the answers, > but you would really help the review by writing those things into the > commit message. > > Alex >
On Tue, 3 Feb 2026 at 17:57, Samuli Piippo <samuli.piippo@gmail.com> wrote: > The function is used at least in PACKAGESPLITFUNCS to filter out all the system packages > and then settings rdepends/recommends/etc for the remaining dynamic packages. > Without this commit, the *-lic license package gets pulled in unintentionally. But what was the issue caused by -lic packages being pulled in? This does not cause problems in testing, so it would be good to know how you arrived at having to change this. All of this should go into the v2 commit message. Alex
Issue is inconsistency, that's all. When lic-pkgs is not used in IMAGE_FEATURES, then only these few license packages are installed. Does autobuilder have a build config with LICENSE_CREATE_PACKAGE = "1" needed to create the -lic packages? I'll update the commit message. On Tue, 3 Feb 2026 at 19:08, Alexander Kanavin <alex.kanavin@gmail.com> wrote: > On Tue, 3 Feb 2026 at 17:57, Samuli Piippo <samuli.piippo@gmail.com> > wrote: > > The function is used at least in PACKAGESPLITFUNCS to filter out all the > system packages > > and then settings rdepends/recommends/etc for the remaining dynamic > packages. > > Without this commit, the *-lic license package gets pulled in > unintentionally. > > But what was the issue caused by -lic packages being pulled in? This > does not cause problems in testing, so it would be good to know how > you arrived at having to change this. > > All of this should go into the v2 commit message. > > Alex >
diff --git a/meta/lib/oe/utils.py b/meta/lib/oe/utils.py index 0128ee411d..2b39d4e0dd 100644 --- a/meta/lib/oe/utils.py +++ b/meta/lib/oe/utils.py @@ -236,7 +236,7 @@ def packages_filter_out_system(d): PN-dbg PN-doc PN-locale-eb-gb removed. """ pn = d.getVar('PN') - pkgfilter = [pn + suffix for suffix in ('', '-dbg', '-dev', '-doc', '-locale', '-staticdev', '-src')] + pkgfilter = [pn + suffix for suffix in ('', '-dbg', '-dev', '-doc', '-locale', '-staticdev', '-src', '-lic')] localepkg = pn + "-locale-" pkgs = []
Make packages_filter_out_system() filter out also the license (-lic) packages. Signed-off-by: Samuli Piippo <samuli.piippo@qt.io> --- meta/lib/oe/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)