diff mbox series

[16/17] python3-wheel: upgrade 0.46.1 -> 0.46.3

Message ID 20260126123844.1052-5-wangmy@fujitsu.com
State Accepted, archived
Commit 31fc221d2330b15148f4d4d649fe9a1507cc5240
Headers show
Series [01/17] bind: upgrade 9.20.17 -> 9.20.18 | expand

Commit Message

Wang Mingyu Jan. 26, 2026, 12:38 p.m. UTC 
From: Wang Mingyu <wangmy@fujitsu.com>

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 .../python/{python3-wheel_0.46.1.bb => python3-wheel_0.46.3.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-devtools/python/{python3-wheel_0.46.1.bb => python3-wheel_0.46.3.bb} (89%)

Comments

Mathieu Dubois-Briand Jan. 28, 2026, 4:44 p.m. UTC | #1 
On Mon Jan 26, 2026 at 1:38 PM CET, wangmy via lists.openembedded.org wrote:
> From: Wang Mingyu <wangmy@fujitsu.com>
>
> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> ---

Hi Wang,

It looks like we also have a failing ptest with this one. I'm not sure
why id didn't show on my previous builds, either it is linked with other
commits or it's a bit intermittent.

Failed ptests:
{'python3-wheel': ['tests/test_metadata.py:test_pkginfo_to_metadata']}

https://autobuilder.yoctoproject.org/valkyrie/#/builders/56/builds/1004
https://autobuilder.yoctoproject.org/valkyrie/#/builders/61/builds/2963

Thanks,
Mathieu
Wang Mingyu Jan. 29, 2026, 8:06 a.m. UTC | #2 
The failure occurs in the test_pkginfo_to_metadatatest with the following error:
FAILED tests/test_metadata.py::test_pkginfo_to_metadata - assert [('Metadata-V...win32"'), ...] == [('Metadata-V...win32"'), ...]
At index 3 diff: ('Requires-Dist', 'pip@ https://github.com/pypa/pip/archive/1.3.1.zip') 
               != ('Requires-Dist', 'pip @ https://github.com/pypa/pip/archive/1.3.1.zip')
Root cause analysis:
The issue was introduced in wheel version 0.46.3, where the upstream maintainers modified the test expectations in tests/test_metadata.py. Specifically, they changed the expected @symbol spacing format:
Upstream change (in wheel 0.46.3):
-      ("Requires-Dist", "pip@ https://github.com/pypa/pip/archive/1.3.1.zip"),
+      ("Requires-Dist", "pip @ https://github.com/pypa/pip/archive/1.3.1.zip"),

-      ("Requires-Dist", 'foo@ http://host/foo.zip ; sys_platform == "win32"'),
+      ("Requires-Dist", 'foo @ http://host/foo.zip ; sys_platform == "win32"'),

-      ("Requires-Dist", 'bar@ http://host/bar.zip ; extra == "extra"'),
+      ("Requires-Dist", 'bar @ http://host/bar.zip ; extra == "extra"'),

However, the actual implementation in wheel/metadata.pystill produces the old format (pip@ https://...), creating a mismatch between test expectations and code behavior.
The conflict:
Test expects: "pip @ https://..."(space before @)
Code produces: "pip@ https://..."(space after @)

While we could simply revert the test file to match the implementation, this would nullify the upstream change without understanding its purpose. The upstream commit message indicates "Fixed test failures due to metadata normalization changes," suggesting this change was intentional.

I have already reported this inconsistency to the wheel upstream team

  --
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST)
No.6 Wenzhu Road, Nanjing, 210012, China
TEL：+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com

> -----Original Message-----
> From: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
> Sent: Thursday, January 29, 2026 12:45 AM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>;
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 16/17] python3-wheel: upgrade 0.46.1 -> 0.46.3
> 
> On Mon Jan 26, 2026 at 1:38 PM CET, wangmy via lists.openembedded.org
> wrote:
> > From: Wang Mingyu <wangmy@fujitsu.com>
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> 
> Hi Wang,
> 
> It looks like we also have a failing ptest with this one. I'm not sure why id didn't
> show on my previous builds, either it is linked with other commits or it's a bit
> intermittent.
> 
> Failed ptests:
> {'python3-wheel': ['tests/test_metadata.py:test_pkginfo_to_metadata']}
> 
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/56/builds/1004
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/61/builds/2963
> 
> Thanks,
> Mathieu
> 
> --
> Mathieu Dubois-Briand, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Wang Mingyu Feb. 3, 2026, 9:09 a.m. UTC | #3 
--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST)
No.6 Wenzhu Road, Nanjing, 210012, China
TEL：+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com

> -----Original Message-----
> From: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
> Sent: Thursday, January 29, 2026 12:45 AM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>;
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 16/17] python3-wheel: upgrade 0.46.1 -> 0.46.3
> 
> On Mon Jan 26, 2026 at 1:38 PM CET, wangmy via lists.openembedded.org
> wrote:
> > From: Wang Mingyu <wangmy@fujitsu.com>
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> 
> Hi Wang,
> 
> It looks like we also have a failing ptest with this one. I'm not sure why id didn't
> show on my previous builds, either it is linked with other commits or it's a bit
> intermittent.
> 
> Failed ptests:
> {'python3-wheel': ['tests/test_metadata.py:test_pkginfo_to_metadata']}
> 
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/56/builds/1004
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/61/builds/2963
> 
> Thanks,
> Mathieu
> 
> --
> Mathieu Dubois-Briand, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Wang Mingyu Feb. 3, 2026, 9:13 a.m. UTC | #4 
When python3-packaging updated to 26.0, this ptest will pass.

  --
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST)
No.6 Wenzhu Road, Nanjing, 210012, China
TEL：+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com

> -----Original Message-----
> From: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
> Sent: Thursday, January 29, 2026 12:45 AM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>;
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 16/17] python3-wheel: upgrade 0.46.1 -> 0.46.3
> 
> On Mon Jan 26, 2026 at 1:38 PM CET, wangmy via lists.openembedded.org
> wrote:
> > From: Wang Mingyu <wangmy@fujitsu.com>
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> 
> Hi Wang,
> 
> It looks like we also have a failing ptest with this one. I'm not sure why id didn't
> show on my previous builds, either it is linked with other commits or it's a bit
> intermittent.
> 
> Failed ptests:
> {'python3-wheel': ['tests/test_metadata.py:test_pkginfo_to_metadata']}
> 
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/56/builds/1004
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/61/builds/2963
> 
> Thanks,
> Mathieu
> 
> --
> Mathieu Dubois-Briand, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
diff mbox series

Patch

diff --git a/meta/recipes-devtools/python/python3-wheel_0.46.1.bb b/meta/recipes-devtools/python/python3-wheel_0.46.3.bb
similarity index 89%
rename from meta/recipes-devtools/python/python3-wheel_0.46.1.bb
rename to meta/recipes-devtools/python/python3-wheel_0.46.3.bb
index 058af2f0e7..2545e5496e 100644
--- a/meta/recipes-devtools/python/python3-wheel_0.46.1.bb
+++ b/meta/recipes-devtools/python/python3-wheel_0.46.3.bb
@@ -4,7 +4,7 @@  SECTION = "devel/python"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=7ffb0db04527cfe380e4f2726bd05ebf"
 
-SRC_URI[sha256sum] = "fd477efb5da0f7df1d3c76c73c14394002c844451bd63229d8570f376f5e6a38"
+SRC_URI[sha256sum] = "e3e79874b07d776c40bd6033f8ddf76a7dad46a7b8aa1b2787a83083519a1803"
 
 inherit python_flit_core pypi ptest-python-pytest