diff mbox series

[v2] icu: split at '.' instead of '-' for major version

Message ID 20260114-icu-major-version-fix-v2-1-bc4a5c9295ee@phytec.de
State New
Headers show
Series [v2] icu: split at '.' instead of '-' for major version | expand

Commit Message

Yannic Moog Jan. 14, 2026, 9:32 a.m. UTC 
With version 78.1, icu adopted '.' as separator between major and minor
version. With the upgrade commit, ICU_MAJOR_VER wasn't updated and still
tried to split versions with '-' instead of '.'. Fix by using '.' as
separator.

The error was missed with poky, because PACKAGECONFIG does not contain
make-icudata. See

do_make_icudata:class-target () {
    ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0', d)}
    [...]
    install -Dm644 ${S}/data/out/icudt${ICU_MAJOR_VER}l.dat ${S}/data/in/icudt${ICU_MAJOR_VER}l.dat
}

for which the install -Dm644 [...] command above would fail when
PACKAGECONFIG contains make-icudata.

Fixes: 479d48503dd2 ("upgrade 77-1 -> 78.1")
Signed-off-by: Yannic Moog <y.moog@phytec.de>
---
Changes in v2:
- improve commit message by explaining why icu error is not seen with
  poky
---
 meta/recipes-support/icu/icu_78.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: dbb0defb5e345b17211ca54d2b9d6237dede60f8
change-id: 20260113-icu-major-version-fix-5b8806a74fe0

Best regards,
diff mbox series

Patch

diff --git a/meta/recipes-support/icu/icu_78.1.bb b/meta/recipes-support/icu/icu_78.1.bb
index 8827f05f5190ddd364fd9f0a139ca6588809e04e..ee7245c27bf101da3623658d044239c45859d6f0 100644
--- a/meta/recipes-support/icu/icu_78.1.bb
+++ b/meta/recipes-support/icu/icu_78.1.bb
@@ -13,7 +13,7 @@  CVE_PRODUCT = "international_components_for_unicode"
 S = "${UNPACKDIR}/icu/source"
 STAGING_ICU_DIR_NATIVE = "${STAGING_DATADIR_NATIVE}/${BPN}/${PV}"
 
-ICU_MAJOR_VER = "${@d.getVar('PV').split('-')[0]}"
+ICU_MAJOR_VER = "${@d.getVar('PV').split('.')[0]}"
 
 inherit autotools pkgconfig github-releases