diff mbox series

[v3] overlayfs: Fix the QA skip for ignored mounts

Message ID 20260113093218.348105-1-uvv.mail@gmail.com
State New
Headers show
Series [v3] overlayfs: Fix the QA skip for ignored mounts | expand

Commit Message

Vyacheslav Yurkov Jan. 13, 2026, 9:32 a.m. UTC 
From: Vyacheslav Yurkov <uvv.mail@gmail.com>

The supressing of QA check for mounts should happens twice, at parsing stage
and at rootfs postprocessing. If the mount point is configured to be skipped,
but it is still present in the configuration (machine or distro), then the
parsing would complain.

Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
---
 meta/lib/oe/overlayfs.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Antonin Godard Jan. 14, 2026, 1:34 p.m. UTC | #1 
Hi,

You have sent multiple versions of some patches (v3 for 1/4, v2 for the rest,
I think): it's not straightforward for maintainers to follow which patch version
to apply.

I also see Paul has made some comment about the naming order of the patch
titles.

Can you take Paul's comments into account, and can you please re-send the series
with the proper versions of the patches? All patches should have the same
version.

Thanks!
Antonin
diff mbox series

Patch

diff --git a/meta/lib/oe/overlayfs.py b/meta/lib/oe/overlayfs.py
index 8b88900f71..dbfed317c0 100644
--- a/meta/lib/oe/overlayfs.py
+++ b/meta/lib/oe/overlayfs.py
@@ -36,7 +36,8 @@  def unitFileList(d):
     # check that we have required mount points set first
     requiredMountPoints = d.getVarFlags('OVERLAYFS_WRITABLE_PATHS')
     for mountPoint in requiredMountPoints:
-        if mountPoint not in overlayMountPoints:
+        qaSkip = (d.getVarFlag("OVERLAYFS_QA_SKIP", mountPoint) or "").split()
+        if mountPoint not in overlayMountPoints and not "mount-configured" in qaSkip:
             bb.fatal("Missing required mount point for OVERLAYFS_MOUNT_POINT[%s] in your MACHINE configuration" % mountPoint)
 
     for mountPoint in overlayMountPoints: