| Message ID | 20260107063605.3838495-1-mohammad.rafi.shaik@oss.qualcomm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] alsa-utils: Include upstream fix for unsupported bit format | expand |
On Wed, Jan 7, 2026 at 4:44 PM Mohammad Rafi Shaik via lists.openembedded.org <mohammad.rafi.shaik=oss.qualcomm.com@lists.openembedded.org> wrote: > > Include upstream patch addressing the unsupported bit format issue > in arecord/aplay. > > Commit: > https://github.com/alsa-project/alsa-utils/commit/a12ec83fa93e16a76f5c57f128f819dfe332f96c > > Upstream change log: > https://www.alsa-project.org/wiki/Changes_v1.2.15_v1.2.15.1#aplay/arecord > There's already a patch on list to upgrade to this version. Thanks, Anuj
On 1/7/2026 2:35 PM, Anuj Mittal wrote: > On Wed, Jan 7, 2026 at 4:44 PM Mohammad Rafi Shaik via > lists.openembedded.org > <mohammad.rafi.shaik=oss.qualcomm.com@lists.openembedded.org> wrote: >> >> Include upstream patch addressing the unsupported bit format issue >> in arecord/aplay. >> >> Commit: >> https://github.com/alsa-project/alsa-utils/commit/a12ec83fa93e16a76f5c57f128f819dfe332f96c >> >> Upstream change log: >> https://www.alsa-project.org/wiki/Changes_v1.2.15_v1.2.15.1#aplay/arecord >> > > There's already a patch on list to upgrade to this version. > ACK, Thanks for the update. will drop this fix. Best Regards, Rafi. > Thanks, > > Anuj
diff --git a/meta/recipes-multimedia/alsa/alsa-utils-1.2.15/0001-aplay-add-missing-break-before-the-default-case.patch b/meta/recipes-multimedia/alsa/alsa-utils-1.2.15/0001-aplay-add-missing-break-before-the-default-case.patch new file mode 100644 index 0000000000..53366e6f61 --- /dev/null +++ b/meta/recipes-multimedia/alsa/alsa-utils-1.2.15/0001-aplay-add-missing-break-before-the-default-case.patch @@ -0,0 +1,32 @@ +From a12ec83fa93e16a76f5c57f128f819dfe332f96c Mon Sep 17 00:00:00 2001 +From: Bard Liao <yung-chuan.liao@linux.intel.com> +Date: Tue, 16 Dec 2025 21:55:54 +0800 +Subject: [PATCH] aplay: add missing break before the default case + +Add the break before the default case back. Otherwise, all cases will +fall into the default/error case. + +Closes: https://github.com/alsa-project/alsa-utils/pull/315 +Fixes: e78583ab7cde ("aplay: reorganize format handling in begin_wave()") +Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> +Signed-off-by: Jaroslav Kysela <perex@perex.cz> +Upstream-Status: Backport [a12ec83fa93e16a76f5c57f128f819dfe332f96c] +--- + aplay/aplay.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/aplay/aplay.c b/aplay/aplay.c +index 63a5214..737d087 100644 +--- a/aplay/aplay.c ++++ b/aplay/aplay.c +@@ -2731,6 +2731,7 @@ static void begin_wave(int fd, size_t cnt) + case SND_PCM_FORMAT_S32_LE: + case SND_PCM_FORMAT_FLOAT_LE: + case SND_PCM_FORMAT_S24_3LE: ++ break; + default: + _format: + error(_("Wave doesn't support %s format..."), snd_pcm_format_name(hwparams.format)); +-- +2.34.1 + diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.bb index 09b3de81f4..144e9dfad3 100644 --- a/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.bb +++ b/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.bb @@ -25,7 +25,8 @@ PACKAGECONFIG[manpages] = "--enable-xmlto, --disable-xmlto, xmlto-native docbook # alsa-utils specified in SRC_URI due to alsa-utils-scripts recipe SRC_URI = "https://www.alsa-project.org/files/pub/utils/alsa-utils-${PV}.tar.bz2 \ - file://0001-alsactl-fix-build-when-in-subdirectory.patch" + file://0001-alsactl-fix-build-when-in-subdirectory.patch \ + file://0001-aplay-add-missing-break-before-the-default-case.patch" SRC_URI[sha256sum] = "d3183d2ed2d69e9143c5beb97036267c3fdabfe8bfbea8bc6863f17b1f0b568e" # On build machines with python-docutils (not python3-docutils !!) installed
Include upstream patch addressing the unsupported bit format issue in arecord/aplay. Commit: https://github.com/alsa-project/alsa-utils/commit/a12ec83fa93e16a76f5c57f128f819dfe332f96c Upstream change log: https://www.alsa-project.org/wiki/Changes_v1.2.15_v1.2.15.1#aplay/arecord Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> --- ...issing-break-before-the-default-case.patch | 32 +++++++++++++++++++ .../alsa/alsa-utils_1.2.15.bb | 3 +- 2 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-multimedia/alsa/alsa-utils-1.2.15/0001-aplay-add-missing-break-before-the-default-case.patch