| Message ID | 20260107-create-pr-v1-1-bf9a9c5eae06@pbarker.dev |
|---|---|
| State | Under Review |
| Headers | show |
| Series | create-pull-request: Keep commit hash to be pulled in cover email | expand |
diff --git a/scripts/create-pull-request b/scripts/create-pull-request index 885105fab3da..5c4414ecd5f7 100755 --- a/scripts/create-pull-request +++ b/scripts/create-pull-request @@ -219,7 +219,7 @@ fi # The cover letter already has a diffstat, remove it from the pull-msg # before inserting it. -sed -n "0,\#$REMOTE_URL# p" "$PM" | sed -i "/BLURB HERE/ r /dev/stdin" "$CL" +sed -n "0,\#^----------------------------------------------------------------# p" "$PM" | sed -i "/BLURB HERE/ r /dev/stdin" "$CL" rm "$PM" # If this is an RFC, make that clear in the cover letter
The cover email mangling in create-pull-request was cutting off the actual commit hash to be pulled, making it difficult to verify that the changes a maintainer merges exactly match those intended by the pull request author. The extra lines we want to include are, for example from a recent whinlatter stable branch PR: for you to fetch changes up to 6c4c6d39ea3202d756acc13f8ce81b114a468541: cups: upgrade from 2.4.14 to 2.4.15 (2025-12-29 09:49:31 -0800) Signed-off-by: Paul Barker <paul@pbarker.dev> --- scripts/create-pull-request | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 0ed4776533145c901611d7f4f942490e33481335 change-id: 20260107-create-pr-9aee6b8b435c Best regards,