| Message ID | 20251224141659.2218381-1-uvv.mail@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/4] overlayfs: Fix QA failure | expand |
On Wed, 2025-12-24 at 14:16 +0000, Vyacheslav Yurkov via lists.openembedded.org wrote: > From: Vyacheslav Yurkov <uvv.mail@gmail.com> > > The QA check for skipped mounts happens twice, at parsing stage and at > rootfs postprocessing. Fix the former, because it didn't happen properly. > > Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com> > --- > meta/lib/oe/overlayfs.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/lib/oe/overlayfs.py b/meta/lib/oe/overlayfs.py > index 8b88900f71..dbfed317c0 100644 > --- a/meta/lib/oe/overlayfs.py > +++ b/meta/lib/oe/overlayfs.py > @@ -36,7 +36,8 @@ def unitFileList(d): > # check that we have required mount points set first > requiredMountPoints = d.getVarFlags('OVERLAYFS_WRITABLE_PATHS') > for mountPoint in requiredMountPoints: > - if mountPoint not in overlayMountPoints: > + qaSkip = (d.getVarFlag("OVERLAYFS_QA_SKIP", mountPoint) or "").split() > + if mountPoint not in overlayMountPoints and not "mount-configured" in qaSkip: > bb.fatal("Missing required mount point for OVERLAYFS_MOUNT_POINT[%s] in your MACHINE configuration" % mountPoint) > > for mountPoint in overlayMountPoints: Thanks for the patches! The review has been delayed a bit by the holidays... We need more explanation in the commit message of why the QA check was happening twice and why it wasn't happening properly at parsing time. Also, when you send a v2 (or v3, etc) patch series, please include a note on what has changed since the previous version, either after the commit message delimiter (the first '---' line) or in a cover letter for the series. That makes review much easier! Best regards,
diff --git a/meta/lib/oe/overlayfs.py b/meta/lib/oe/overlayfs.py index 8b88900f71..dbfed317c0 100644 --- a/meta/lib/oe/overlayfs.py +++ b/meta/lib/oe/overlayfs.py @@ -36,7 +36,8 @@ def unitFileList(d): # check that we have required mount points set first requiredMountPoints = d.getVarFlags('OVERLAYFS_WRITABLE_PATHS') for mountPoint in requiredMountPoints: - if mountPoint not in overlayMountPoints: + qaSkip = (d.getVarFlag("OVERLAYFS_QA_SKIP", mountPoint) or "").split() + if mountPoint not in overlayMountPoints and not "mount-configured" in qaSkip: bb.fatal("Missing required mount point for OVERLAYFS_MOUNT_POINT[%s] in your MACHINE configuration" % mountPoint) for mountPoint in overlayMountPoints: