| Message ID | 20251217093409.914045-2-koen.kooi@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix and adjust ukify packaging | expand |
On Wed Dec 17, 2025 at 10:34 AM CET, Koen Kooi via lists.openembedded.org wrote: > From the upstream website: > Pyzstd module provides classes and functions for compressing and > decompressing data, using Facebook's Zstandard (or zstd as short name) > algorithm. > > This recipe is being moved over for systemd 258.x, the 'ukify' tool > depends on this. > > Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com> > --- Hi Koen, Thanks for your patch. It look like this is failing on the autobuilder in various configurations, probably only with poky-altcfg: ERROR: python3-pyzstd-0.17.0-r0 do_package_qa: Fatal QA errors were found, failing task. ... ERROR: python3-pyzstd-0.17.0-r0 do_package_qa: QA Issue: supports ptests but is not included in oe-core's ptest-packagelists.inc [missing-ptest] https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2848 https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2837 https://autobuilder.yoctoproject.org/valkyrie/#/builders/22/builds/2894 https://autobuilder.yoctoproject.org/valkyrie/#/builders/74/builds/2848 https://autobuilder.yoctoproject.org/valkyrie/#/builders/95/builds/2829 Can you have a look at this issue? Thanks, Mathieu
> Op 17 dec 2025, om 15:47 heeft Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> het volgende geschreven: > > On Wed Dec 17, 2025 at 10:34 AM CET, Koen Kooi via lists.openembedded.org wrote: >> From the upstream website: >> Pyzstd module provides classes and functions for compressing and >> decompressing data, using Facebook's Zstandard (or zstd as short name) >> algorithm. >> >> This recipe is being moved over for systemd 258.x, the 'ukify' tool >> depends on this. >> >> Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com> >> --- > > Hi Koen, > > Thanks for your patch. > > It look like this is failing on the autobuilder in various > configurations, probably only with poky-altcfg: > > ERROR: python3-pyzstd-0.17.0-r0 do_package_qa: Fatal QA errors were found, failing task. > ... > ERROR: python3-pyzstd-0.17.0-r0 do_package_qa: QA Issue: supports ptests but is not included in oe-core's ptest-packagelists.inc [missing-ptest] > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2848 > https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2837 > https://autobuilder.yoctoproject.org/valkyrie/#/builders/22/builds/2894 > https://autobuilder.yoctoproject.org/valkyrie/#/builders/74/builds/2848 > https://autobuilder.yoctoproject.org/valkyrie/#/builders/95/builds/2829 > > Can you have a look at this issue? Sure, but I have no way of testing that patch :) V3 is on its way. regards, Koen > > Thanks, > Mathieu > > -- > Mathieu Dubois-Briand, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
On Wed Dec 17, 2025 at 4:09 PM CET, Koen Kooi wrote: > > >> Op 17 dec 2025, om 15:47 heeft Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> het volgende geschreven: >> >> On Wed Dec 17, 2025 at 10:34 AM CET, Koen Kooi via lists.openembedded.org wrote: >>> From the upstream website: >>> Pyzstd module provides classes and functions for compressing and >>> decompressing data, using Facebook's Zstandard (or zstd as short name) >>> algorithm. >>> >>> This recipe is being moved over for systemd 258.x, the 'ukify' tool >>> depends on this. >>> >>> Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com> >>> --- >> >> Hi Koen, >> >> Thanks for your patch. >> >> It look like this is failing on the autobuilder in various >> configurations, probably only with poky-altcfg: >> >> ERROR: python3-pyzstd-0.17.0-r0 do_package_qa: Fatal QA errors were found, failing task. >> ... >> ERROR: python3-pyzstd-0.17.0-r0 do_package_qa: QA Issue: supports ptests but is not included in oe-core's ptest-packagelists.inc [missing-ptest] >> >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2848 >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2837 >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/22/builds/2894 >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/74/builds/2848 >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/95/builds/2829 >> >> Can you have a look at this issue? > > Sure, but I have no way of testing that patch :) V3 is on its way. > This is a build-time issue, so I suspect you should be able to reproduce it with: DISTRO=poky-altcfg bitbake python3-pyzstd Thanks, Mathieu
diff --git a/meta/recipes-devtools/python/python3-pyzstd/0001-Remove-setuptools-version-limit-of-74.patch b/meta/recipes-devtools/python/python3-pyzstd/0001-Remove-setuptools-version-limit-of-74.patch new file mode 100644 index 0000000000..f2910322ff --- /dev/null +++ b/meta/recipes-devtools/python/python3-pyzstd/0001-Remove-setuptools-version-limit-of-74.patch @@ -0,0 +1,27 @@ +From bc9b975c9f41e43481a2eb0623b4180926baecec Mon Sep 17 00:00:00 2001 +From: Khem Raj <raj.khem@gmail.com> +Date: Wed, 9 Apr 2025 14:38:31 -0700 +Subject: [PATCH] Remove setuptools version limit of '74' + +Upstream sticks to 0.74 since setuptools have dropped msvc9compiler +support beyond that which is needed for python 3.9 on windows. We +do not have this problem on Linux + +Upstream-Status: Inappropriate [OE-specific] +Signed-off-by: Khem Raj <raj.khem@gmail.com> +--- + pyproject.toml | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/pyproject.toml b/pyproject.toml +index dd885e4..5d4d511 100644 +--- a/pyproject.toml ++++ b/pyproject.toml +@@ -1,6 +1,6 @@ + [build-system] + # setuptools 64+ support --build-option + # setuptools 74+ drops distutils.msvc9compiler required for Python 3.9 under Windows +-requires = ["setuptools>=64,<74"] ++requires = ["setuptools>=64"] + backend-path = ["build_script"] + build-backend = "pyzstd_pep517" diff --git a/meta/recipes-devtools/python/python3-pyzstd_0.17.0.bb b/meta/recipes-devtools/python/python3-pyzstd_0.17.0.bb new file mode 100644 index 0000000000..0ed6cd47c7 --- /dev/null +++ b/meta/recipes-devtools/python/python3-pyzstd_0.17.0.bb @@ -0,0 +1,19 @@ +DESCRIPTION = "Pyzstd module provides classes and functions for compressing and \ +decompressing data, using Facebookâs Zstandard (or zstd as short name) algorithm." +HOMEPAGE = "https://github.com/animalize/pyzstd" +SECTION = "devel/python" + +LICENSE = "BSD-3-Clause" +LIC_FILES_CHKSUM = "file://LICENSE;md5=aedb5a2679cd1552fb61c181ef974b9e" + +PYPI_PACKAGE = "pyzstd" + +SRC_URI += "file://0001-Remove-setuptools-version-limit-of-74.patch" +SRC_URI[sha256sum] = "d84271f8baa66c419204c1dd115a4dec8b266f8a2921da21b81764fa208c1db6" + +inherit pypi python_setuptools_build_meta ptest-python-pytest + +# clang-16 with -flto segfaults on arm, therefore ignore flto for now +do_configure:append:arm:toolchain-clang() { + sed -i -e "s|'-flto'|''|" ${S}/setup.py +}
From the upstream website: Pyzstd module provides classes and functions for compressing and decompressing data, using Facebook's Zstandard (or zstd as short name) algorithm. This recipe is being moved over for systemd 258.x, the 'ukify' tool depends on this. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com> --- Changes since v1: * Adjusted pyzstd patch to not specify an upper limit to the setuptools version, as suggested by Alexander Kanavin. ...emove-setuptools-version-limit-of-74.patch | 27 +++++++++++++++++++ .../python/python3-pyzstd_0.17.0.bb | 19 +++++++++++++ 2 files changed, 46 insertions(+) create mode 100644 meta/recipes-devtools/python/python3-pyzstd/0001-Remove-setuptools-version-limit-of-74.patch create mode 100644 meta/recipes-devtools/python/python3-pyzstd_0.17.0.bb