diff mbox series

[V2] bash-completion.bbclass: prepend bash-completion to PACKAGES

Message ID 20251109173407.1320188-1-liu.ming50@gmail.com
State New
Headers show
Series [V2] bash-completion.bbclass: prepend bash-completion to PACKAGES | expand

Commit Message

Ming Liu Nov. 9, 2025, 5:34 p.m. UTC
It was observed when FILES:${PN} contains "${sysconfdir}" or
"${datadir}", the bash-completion files wont be installed to
bash-completion package.

Fix it by prepending bash-completion package to PACKAGES, this
ensures bash-completion package get the files packaged before PN.

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 meta/classes-recipe/bash-completion.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ross Burton Nov. 10, 2025, 5:53 p.m. UTC | #1
On 9 Nov 2025, at 17:34, Ming Liu via lists.openembedded.org <liu.ming50=gmail.com@lists.openembedded.org> wrote:
> 
> It was observed when FILES:${PN} contains "${sysconfdir}" or
> "${datadir}", the bash-completion files wont be installed to
> bash-completion package.
> 
> Fix it by prepending bash-completion package to PACKAGES, this
> ensures bash-completion package get the files packaged before PN.
> 
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
> meta/classes-recipe/bash-completion.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/bash-completion.bbclass b/meta/classes-recipe/bash-completion.bbclass
> index b656e76c09..e337c2045d 100644
> --- a/meta/classes-recipe/bash-completion.bbclass
> +++ b/meta/classes-recipe/bash-completion.bbclass
> @@ -6,7 +6,7 @@
> 
> DEPENDS:append:class-target = " bash-completion"
> 
> -PACKAGES += "${PN}-bash-completion"
> +PACKAGES:prepend = "${PN}-bash-completion “

Please use PACKAGES_BEFORE_PN for this, and just +=.

Ross
diff mbox series

Patch

diff --git a/meta/classes-recipe/bash-completion.bbclass b/meta/classes-recipe/bash-completion.bbclass
index b656e76c09..e337c2045d 100644
--- a/meta/classes-recipe/bash-completion.bbclass
+++ b/meta/classes-recipe/bash-completion.bbclass
@@ -6,7 +6,7 @@ 
 
 DEPENDS:append:class-target = " bash-completion"
 
-PACKAGES += "${PN}-bash-completion"
+PACKAGES:prepend = "${PN}-bash-completion "
 
 FILES:${PN}-bash-completion = "${datadir}/bash-completion ${sysconfdir}/bash_completion.d"