| Message ID | 20251106181103.515146-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | libclc: Add misssing quotes around target list | expand |
On Fri, Nov 7, 2025 at 7:44 AM Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: > > Defualt for LIBCLC_TARGETS is `all` so a single there is a typo -> "Defualt" > target is ok but when its overidden with a semi-colon > separated list to use a subset of targets, e.g. > > LIBCLC_TARGETS:class-nativesdk = "amdgcn--;amdgcn--amdhsa;nvptx--;nvptx64--;nvptx--nvidiacl;nvptx64--nvidiacl" > > cmake rejects it. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-devtools/clang/libclc_git.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/clang/libclc_git.bb b/meta/recipes-devtools/clang/libclc_git.bb > index 60909339e70..c4b4881542f 100644 > --- a/meta/recipes-devtools/clang/libclc_git.bb > +++ b/meta/recipes-devtools/clang/libclc_git.bb > @@ -21,7 +21,7 @@ B_NATIVE = "${B}-native" > # Semicolon-separated list of targets to build > LIBCLC_TARGETS ?= "all" > > -EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD=${LIBCLC_TARGETS}" > +EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD='${LIBCLC_TARGETS}'" > EXTRA_OECMAKE:append:class-target = " -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins" > EXTRA_OECMAKE:append:class-nativesdk = " -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins" > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#225985): https://lists.openembedded.org/g/openembedded-core/message/225985 > Mute This Topic: https://lists.openembedded.org/mt/116157847/3619737 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ankur.tyagi85@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Thu, Nov 6, 2025 at 11:00 AM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote: > On Fri, Nov 7, 2025 at 7:44 AM Khem Raj via lists.openembedded.org > <raj.khem=gmail.com@lists.openembedded.org> wrote: > > > > Defualt for LIBCLC_TARGETS is `all` so a single > > there is a typo -> "Defualt" > indeed. Thanks > > > target is ok but when its overidden with a semi-colon > > separated list to use a subset of targets, e.g. > > > > LIBCLC_TARGETS:class-nativesdk = > "amdgcn--;amdgcn--amdhsa;nvptx--;nvptx64--;nvptx--nvidiacl;nvptx64--nvidiacl" > > > > cmake rejects it. > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta/recipes-devtools/clang/libclc_git.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-devtools/clang/libclc_git.bb > b/meta/recipes-devtools/clang/libclc_git.bb > > index 60909339e70..c4b4881542f 100644 > > --- a/meta/recipes-devtools/clang/libclc_git.bb > > +++ b/meta/recipes-devtools/clang/libclc_git.bb > > @@ -21,7 +21,7 @@ B_NATIVE = "${B}-native" > > # Semicolon-separated list of targets to build > > LIBCLC_TARGETS ?= "all" > > > > -EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD=${LIBCLC_TARGETS}" > > +EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD='${LIBCLC_TARGETS}'" > > EXTRA_OECMAKE:append:class-target = " > -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins" > > EXTRA_OECMAKE:append:class-nativesdk = " > -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins" > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#225985): > https://lists.openembedded.org/g/openembedded-core/message/225985 > > Mute This Topic: https://lists.openembedded.org/mt/116157847/3619737 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > ankur.tyagi85@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > > >
diff --git a/meta/recipes-devtools/clang/libclc_git.bb b/meta/recipes-devtools/clang/libclc_git.bb index 60909339e70..c4b4881542f 100644 --- a/meta/recipes-devtools/clang/libclc_git.bb +++ b/meta/recipes-devtools/clang/libclc_git.bb @@ -21,7 +21,7 @@ B_NATIVE = "${B}-native" # Semicolon-separated list of targets to build LIBCLC_TARGETS ?= "all" -EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD=${LIBCLC_TARGETS}" +EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD='${LIBCLC_TARGETS}'" EXTRA_OECMAKE:append:class-target = " -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins" EXTRA_OECMAKE:append:class-nativesdk = " -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins"
Defualt for LIBCLC_TARGETS is `all` so a single target is ok but when its overidden with a semi-colon separated list to use a subset of targets, e.g. LIBCLC_TARGETS:class-nativesdk = "amdgcn--;amdgcn--amdhsa;nvptx--;nvptx64--;nvptx--nvidiacl;nvptx64--nvidiacl" cmake rejects it. Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-devtools/clang/libclc_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)