| Message ID | 20251028102341.955681-1-contact@schnwalter.eu |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] core-image-weston: Add wayland as required feature. | expand |
On Tue, 28 Oct 2025 at 11:23, Walter Werner SCHNEIDER via lists.openembedded.org <contact=schnwalter.eu@lists.openembedded.org> wrote: > > Running bitbake on the image without a DISTRO causes a "Nothing PROVIDES > 'weston-xwayland'" error, and it doesn't help new users understand how to > get over the issue. With this change, you are guided by the errors and > can easily fix your image build by either adding the required > DISTRO_FEATURES or by setting a DISTRO, if you know the root cause. Thanks, this is fine. > The fist patch didn't include an explenation. The same also happens when > trying to build core-image-sato without a DISTRO, I will provide a patch > for that, if this is the correct fix for this type of issue. I think it is, but do include an explanation, as this will help review (in particular if someone objects and proposes a different approach). Alex
> if someone objects and proposes a different approach
With this change, you still don't know the root cause. But at least you know that you are missing a DISTRO_FEATURE, a more correct fix would be for the error message to also mention the lack of DISTRO when there's a missing DISTRO_FEATURE, should I also look into adding that kind of message? But maybe in a different patch.
diff --git a/meta/recipes-graphics/images/core-image-weston.bb b/meta/recipes-graphics/images/core-image-weston.bb index 62305cc1ce..96d9c34bfa 100644 --- a/meta/recipes-graphics/images/core-image-weston.bb +++ b/meta/recipes-graphics/images/core-image-weston.bb @@ -4,9 +4,11 @@ IMAGE_FEATURES += "splash package-management ssh-server-dropbear hwcodecs weston LICENSE = "MIT" -inherit core-image +inherit core-image features_check CORE_IMAGE_BASE_INSTALL += "gtk+3-demo" CORE_IMAGE_BASE_INSTALL += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'weston-xwayland matchbox-terminal', '', d)}" QB_MEM = "-m 512" + +REQUIRED_DISTRO_FEATURES = "wayland"
Running bitbake on the image without a DISTRO causes a "Nothing PROVIDES 'weston-xwayland'" error, and it doesn't help new users understand how to get over the issue. With this change, you are guided by the errors and can easily fix your image build by either adding the required DISTRO_FEATURES or by setting a DISTRO, if you know the root cause. Signed-off-by: Walter Werner SCHNEIDER <contact@schnwalter.eu> --- The fist patch didn't include an explenation. The same also happens when trying to build core-image-sato without a DISTRO, I will provide a patch for that, if this is the correct fix for this type of issue. meta/recipes-graphics/images/core-image-weston.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)