| Message ID | 20251027164236.2324092-1-contact@schnwalter.eu |
|---|---|
| State | New |
| Headers | show |
| Series | core-image-weston: Add wayland as required feature. | expand |
On Mon, 27 Oct 2025 at 17:43, Walter Werner SCHNEIDER via
lists.openembedded.org <contact=schnwalter.eu@lists.openembedded.org>
wrote:
> +REQUIRED_DISTRO_FEATURES = "wayland"
It would help to add to the commit message an explanation of what is
improved by the change. What is the issue you ran into?
Alex
On 10/27/25 17:42, Walter Werner SCHNEIDER via lists.openembedded.org wrote: > Signed-off-by: Walter Werner SCHNEIDER <contact@schnwalter.eu> > --- Little bit offtopic, but is the patchtest job down? It supposed to catch empty commit message. (And thinking of it, there hasn't been any mails since a few weeks)
I've provided a v2 version of the patch that includes the reasoning behind the change and a small note that won't be included in the patch regarding core-image-sato, which has a similar problem. Both images can not be built without providing a distro, with REQUIRED_DISTRO_FEATURES and features_check, the build fails with a more clear error.
diff --git a/meta/recipes-graphics/images/core-image-weston.bb b/meta/recipes-graphics/images/core-image-weston.bb index 62305cc1ce..96d9c34bfa 100644 --- a/meta/recipes-graphics/images/core-image-weston.bb +++ b/meta/recipes-graphics/images/core-image-weston.bb @@ -4,9 +4,11 @@ IMAGE_FEATURES += "splash package-management ssh-server-dropbear hwcodecs weston LICENSE = "MIT" -inherit core-image +inherit core-image features_check CORE_IMAGE_BASE_INSTALL += "gtk+3-demo" CORE_IMAGE_BASE_INSTALL += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'weston-xwayland matchbox-terminal', '', d)}" QB_MEM = "-m 512" + +REQUIRED_DISTRO_FEATURES = "wayland"
Signed-off-by: Walter Werner SCHNEIDER <contact@schnwalter.eu> --- meta/recipes-graphics/images/core-image-weston.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)