| Message ID | 20251010075258.2161972-3-hongxu.jia@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v5,1/5] distro/include: Add debug_build.inc when DEBUG_BUILD is enabled | expand |
On Fri, 2025-10-10 at 15:52 +0800, hongxu via lists.openembedded.org wrote: > The debug_build.inc is used to collect debug build configuration, > override INHIBIT_SYSROOT_STRIP for cross and native bbclass when DEBUG_BUILD > is enabled > > Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> > --- > meta/classes-recipe/cross.bbclass | 3 +-- > meta/classes-recipe/native.bbclass | 3 +-- > meta/conf/distro/include/debug_build.inc | 4 ++++ > 3 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/meta/classes-recipe/cross.bbclass b/meta/classes-recipe/cross.bbclass > index 9abf166e50..ede04950b5 100644 > --- a/meta/classes-recipe/cross.bbclass > +++ b/meta/classes-recipe/cross.bbclass > @@ -23,8 +23,7 @@ HOST_CC_ARCH = "${BUILD_CC_ARCH}" > HOST_LD_ARCH = "${BUILD_LD_ARCH}" > HOST_AS_ARCH = "${BUILD_AS_ARCH}" > > -# No strip sysroot when DEBUG_BUILD is enabled > -INHIBIT_SYSROOT_STRIP ?= "${@oe.utils.vartrue('DEBUG_BUILD', '1', '', d)}" > +INHIBIT_SYSROOT_STRIP ??= "" > > export lt_cv_sys_lib_dlsearch_path_spec = "${libdir} ${base_libdir} /lib /lib64 /usr/lib /usr/lib64" > > diff --git a/meta/classes-recipe/native.bbclass b/meta/classes-recipe/native.bbclass > index 7d1fe343fa..b3411d20ca 100644 > --- a/meta/classes-recipe/native.bbclass > +++ b/meta/classes-recipe/native.bbclass > @@ -118,8 +118,7 @@ PATH:prepend = "${COREBASE}/scripts/native-intercept:" > # reused if we manipulate the paths. > SSTATE_SCAN_CMD ?= "${SSTATE_SCAN_CMD_NATIVE}" > > -# No strip sysroot when DEBUG_BUILD is enabled > -INHIBIT_SYSROOT_STRIP ?= "${@oe.utils.vartrue('DEBUG_BUILD', '1', '', d)}" > +INHIBIT_SYSROOT_STRIP ??= "" > > python native_virtclass_handler () { > import re > diff --git a/meta/conf/distro/include/debug_build.inc b/meta/conf/distro/include/debug_build.inc > index c006093345..1062326417 100644 > --- a/meta/conf/distro/include/debug_build.inc > +++ b/meta/conf/distro/include/debug_build.inc > @@ -40,3 +40,7 @@ EXTRA_OECONF:append:pn-nativesdk-debugedit = " --disable-inlined-xxhash" > lcl_maybe_fortify:pn-vim = "" > > CXXFLAGS:append:pn-vulkan-validation-layers = " -DXXH_NO_INLINE_HINTS=1" > + > +# No strip sysroot for cross and native > +INHIBIT_SYSROOT_STRIP:class-cross ?= "1" > +INHIBIT_SYSROOT_STRIP:class-native ?= "1" One key question is whether this still makes sense? In most cases you want to debug target binaries, or native, or cross but it would be unusual to want to do all at the same time other than for test builds. In test builds, you can just add the extra config. Perhaps we should therefore just remove these? Cheers, Richard
On 12/15/25 20:02, Richard Purdie wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Fri, 2025-10-10 at 15:52 +0800, hongxu via lists.openembedded.org wrote: >> The debug_build.inc is used to collect debug build configuration, >> override INHIBIT_SYSROOT_STRIP for cross and native bbclass when DEBUG_BUILD >> is enabled >> >> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> >> --- >> meta/classes-recipe/cross.bbclass | 3 +-- >> meta/classes-recipe/native.bbclass | 3 +-- >> meta/conf/distro/include/debug_build.inc | 4 ++++ >> 3 files changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/meta/classes-recipe/cross.bbclass b/meta/classes-recipe/cross.bbclass >> index 9abf166e50..ede04950b5 100644 >> --- a/meta/classes-recipe/cross.bbclass >> +++ b/meta/classes-recipe/cross.bbclass >> @@ -23,8 +23,7 @@ HOST_CC_ARCH = "${BUILD_CC_ARCH}" >> HOST_LD_ARCH = "${BUILD_LD_ARCH}" >> HOST_AS_ARCH = "${BUILD_AS_ARCH}" >> >> -# No strip sysroot when DEBUG_BUILD is enabled >> -INHIBIT_SYSROOT_STRIP ?= "${@oe.utils.vartrue('DEBUG_BUILD', '1', '', d)}" >> +INHIBIT_SYSROOT_STRIP ??= "" >> >> export lt_cv_sys_lib_dlsearch_path_spec = "${libdir} ${base_libdir} /lib /lib64 /usr/lib /usr/lib64" >> >> diff --git a/meta/classes-recipe/native.bbclass b/meta/classes-recipe/native.bbclass >> index 7d1fe343fa..b3411d20ca 100644 >> --- a/meta/classes-recipe/native.bbclass >> +++ b/meta/classes-recipe/native.bbclass >> @@ -118,8 +118,7 @@ PATH:prepend = "${COREBASE}/scripts/native-intercept:" >> # reused if we manipulate the paths. >> SSTATE_SCAN_CMD ?= "${SSTATE_SCAN_CMD_NATIVE}" >> >> -# No strip sysroot when DEBUG_BUILD is enabled >> -INHIBIT_SYSROOT_STRIP ?= "${@oe.utils.vartrue('DEBUG_BUILD', '1', '', d)}" >> +INHIBIT_SYSROOT_STRIP ??= "" >> >> python native_virtclass_handler () { >> import re >> diff --git a/meta/conf/distro/include/debug_build.inc b/meta/conf/distro/include/debug_build.inc >> index c006093345..1062326417 100644 >> --- a/meta/conf/distro/include/debug_build.inc >> +++ b/meta/conf/distro/include/debug_build.inc >> @@ -40,3 +40,7 @@ EXTRA_OECONF:append:pn-nativesdk-debugedit = " --disable-inlined-xxhash" >> lcl_maybe_fortify:pn-vim = "" >> >> CXXFLAGS:append:pn-vulkan-validation-layers = " -DXXH_NO_INLINE_HINTS=1" >> + >> +# No strip sysroot for cross and native >> +INHIBIT_SYSROOT_STRIP:class-cross ?= "1" >> +INHIBIT_SYSROOT_STRIP:class-native ?= "1" > One key question is whether this still makes sense? > > In most cases you want to debug target binaries, or native, or cross > but it would be unusual to want to do all at the same time other than > for test builds. In test builds, you can just add the extra config. > > Perhaps we should therefore just remove these? Copy, v6 incoming //Hongxu > Cheers, > > Richard
diff --git a/meta/classes-recipe/cross.bbclass b/meta/classes-recipe/cross.bbclass index 9abf166e50..ede04950b5 100644 --- a/meta/classes-recipe/cross.bbclass +++ b/meta/classes-recipe/cross.bbclass @@ -23,8 +23,7 @@ HOST_CC_ARCH = "${BUILD_CC_ARCH}" HOST_LD_ARCH = "${BUILD_LD_ARCH}" HOST_AS_ARCH = "${BUILD_AS_ARCH}" -# No strip sysroot when DEBUG_BUILD is enabled -INHIBIT_SYSROOT_STRIP ?= "${@oe.utils.vartrue('DEBUG_BUILD', '1', '', d)}" +INHIBIT_SYSROOT_STRIP ??= "" export lt_cv_sys_lib_dlsearch_path_spec = "${libdir} ${base_libdir} /lib /lib64 /usr/lib /usr/lib64" diff --git a/meta/classes-recipe/native.bbclass b/meta/classes-recipe/native.bbclass index 7d1fe343fa..b3411d20ca 100644 --- a/meta/classes-recipe/native.bbclass +++ b/meta/classes-recipe/native.bbclass @@ -118,8 +118,7 @@ PATH:prepend = "${COREBASE}/scripts/native-intercept:" # reused if we manipulate the paths. SSTATE_SCAN_CMD ?= "${SSTATE_SCAN_CMD_NATIVE}" -# No strip sysroot when DEBUG_BUILD is enabled -INHIBIT_SYSROOT_STRIP ?= "${@oe.utils.vartrue('DEBUG_BUILD', '1', '', d)}" +INHIBIT_SYSROOT_STRIP ??= "" python native_virtclass_handler () { import re diff --git a/meta/conf/distro/include/debug_build.inc b/meta/conf/distro/include/debug_build.inc index c006093345..1062326417 100644 --- a/meta/conf/distro/include/debug_build.inc +++ b/meta/conf/distro/include/debug_build.inc @@ -40,3 +40,7 @@ EXTRA_OECONF:append:pn-nativesdk-debugedit = " --disable-inlined-xxhash" lcl_maybe_fortify:pn-vim = "" CXXFLAGS:append:pn-vulkan-validation-layers = " -DXXH_NO_INLINE_HINTS=1" + +# No strip sysroot for cross and native +INHIBIT_SYSROOT_STRIP:class-cross ?= "1" +INHIBIT_SYSROOT_STRIP:class-native ?= "1"
The debug_build.inc is used to collect debug build configuration, override INHIBIT_SYSROOT_STRIP for cross and native bbclass when DEBUG_BUILD is enabled Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> --- meta/classes-recipe/cross.bbclass | 3 +-- meta/classes-recipe/native.bbclass | 3 +-- meta/conf/distro/include/debug_build.inc | 4 ++++ 3 files changed, 6 insertions(+), 4 deletions(-)