| Message ID | 20251003150837.39814-1-jon.mason@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] runqemu: remove setting of mem on kernel command line for certain systems | expand |
On Fri, 3 Oct 2025 at 17:08, Jon Mason via lists.openembedded.org <jon.mason=arm.com@lists.openembedded.org> wrote: > > Some emulated hardware will not boot if mem is set on the kernel command Please replace 'some' and 'certain' with actual examples, or rewrite the commit message to remove these vague-on-purpose words altogether. Alex
On Mon, Oct 6, 2025 at 4:59 AM Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote: > > On Fri, 3 Oct 2025 at 17:08, Jon Mason via lists.openembedded.org > <jon.mason=arm.com@lists.openembedded.org> wrote: > > > > Some emulated hardware will not boot if mem is set on the kernel command > > Please replace 'some' and 'certain' with actual examples, or rewrite > the commit message to remove these vague-on-purpose words altogether. Well, this is embarrassing. Ross made that same comment and I sent that change out (see Message-ID: <20251001175702.62563-1-jon.mason@arm.com>, https://lists.openembedded.org/g/openembedded-core/message/224316), but I lost that change somehow when making the v2 change. Let me pull that one off the lists and do a v3 (with this change and the comment change of v2). Sorry and thanks, Jon > Alex > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#224468): https://lists.openembedded.org/g/openembedded-core/message/224468 > Mute This Topic: https://lists.openembedded.org/mt/115571450/3616920 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [jdmason@kudzu.us] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/scripts/runqemu b/scripts/runqemu index 32c7a2aab3b5..a8144aa68c3d 100755 --- a/scripts/runqemu +++ b/scripts/runqemu @@ -884,7 +884,7 @@ to your build configuration. self.set('QB_MEM', qb_mem) mach = self.get('MACHINE') - if not mach.startswith(('qemumips', 'qemux86', 'qemuloongarch64')): + if not mach.startswith(('qemumips', 'qemux86', 'qemuloongarch64')) and self.get('QB_DTB') == "": self.kernel_cmdline_script += ' mem=%s' % self.get('QB_MEM').replace('-m','').strip() + 'M' self.qemu_opt_script += ' %s' % self.get('QB_MEM')
Some emulated hardware will not boot if mem is set on the kernel command line. Also, it is not necessary if the device tree file, as that _should_ have the memory size specified in it. Add a check for QB_DTB and don't set it if specified. Signed-off-by: Jon Mason <jon.mason@arm.com> --- scripts/runqemu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)