| Message ID | 20251002003034.344992-1-rs@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | libx11: create tmpfile dir for x11 domain socket | expand |
On 2 Oct 2025, at 01:30, rs@ti.com wrote: > > From: Randolph Sapp <rs@ti.com> > > Register a volatile directory entry for the x11 domain socket when not > using systemd. This will make sure the directory is always created with > the correct permissions. Systemd already provides their own tmpfile.d > entry for the same behavior. > > Currently some x11 related applications will create this directory if it > doesn't already exist, but this is not true for everything. In addition, > if the application in question isn't started as root, it's possible this > directory can be owned by a non-root user. This isn't an issue by > itself, but it can potentially lead to problems in a multi-user > environment. Feel like this should be in xserver (as the xserver is the one creating the sockets), not libx11. Ross
On Mon Oct 6, 2025 at 5:38 AM CDT, Ross Burton wrote: > On 2 Oct 2025, at 01:30, rs@ti.com wrote: >> >> From: Randolph Sapp <rs@ti.com> >> >> Register a volatile directory entry for the x11 domain socket when not >> using systemd. This will make sure the directory is always created with >> the correct permissions. Systemd already provides their own tmpfile.d >> entry for the same behavior. >> >> Currently some x11 related applications will create this directory if it >> doesn't already exist, but this is not true for everything. In addition, >> if the application in question isn't started as root, it's possible this >> directory can be owned by a non-root user. This isn't an issue by >> itself, but it can potentially lead to problems in a multi-user >> environment. > > Feel like this should be in xserver (as the xserver is the one creating the sockets), not libx11. > > Ross Fair enough. That got me thinking though, with potentially multiple xserver providers, and systemd already shipping it's own version of that tmpfiles entry, should this instead be part of sysvinit? If anything, just to be symmetric? - Randolph
diff --git a/meta/recipes-graphics/xorg-lib/libx11/99_x11 b/meta/recipes-graphics/xorg-lib/libx11/99_x11 new file mode 100644 index 0000000000..53c5b49d10 --- /dev/null +++ b/meta/recipes-graphics/xorg-lib/libx11/99_x11 @@ -0,0 +1 @@ +d root root 1777 /tmp/.X11-unix none diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb b/meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb index 580e44889d..23a4b228a9 100644 --- a/meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb +++ b/meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb @@ -21,7 +21,8 @@ PE = "1" XORG_PN = "libX11" -SRC_URI += "file://disable_tests.patch" +SRC_URI += "file://disable_tests.patch \ + file://99_x11" SRC_URI[sha256sum] = "fa026f9bb0124f4d6c808f9aef4057aad65e7b35d8ff43951cef0abe06bb9a9a" @@ -35,7 +36,17 @@ PACKAGECONFIG[xcms] = "--enable-xcms,--disable-xcms" PACKAGES =+ "${PN}-xcb" -FILES:${PN} += "${datadir}/X11/XKeysymDB ${datadir}/X11/XErrorDB ${datadir}/X11/Xcms.txt" +do_install:append() { + # temporary directory required for x11 domain sockets + # systemd provides their own definition using tmpfiles.d + if ${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'systemd', 'false', 'true', d)}; then + install -d ${D}${sysconfdir}/default/volatiles + install -m 0644 ${UNPACKDIR}/99_x11 ${D}${sysconfdir}/default/volatiles/99_x11 + fi +} + +FILES:${PN} += "${datadir}/X11/XKeysymDB ${datadir}/X11/XErrorDB ${datadir}/X11/Xcms.txt \ + ${libdir}/tmpfiles.d/x11.conf ${sysconfdir}/default/volatiles/99_x11" FILES:${PN}-xcb += "${libdir}/libX11-xcb.so.*" FILES:${PN}-locale += "${datadir}/X11/locale ${libdir}/X11/locale"