| Message ID | 20251001152850.1342075-1-anna-lena.marx@inovex.de |
|---|---|
| State | New |
| Headers | show |
| Series | sqlite3: upgrade 3.48.0 -> 3.50.4 | expand |
On Wed Oct 1, 2025 at 5:28 PM CEST, Anna-Lena Marx via lists.openembedded.org wrote: > With the upgrade to 3.50.4, some configure options changed > as the project switched from `autotools` to `autosetup`. > The PACKAGECONFIG "dyn_ext" is not longer available. > Besides, the default CONFIGUREOPTS "target", "exec_prefix" > and "oldincludedir" became invalid. > > Changelog: https://sqlite.org/releaselog/3_50_4.html > > Signed-off-by: Anna-Lena Marx <anna-lena.marx@inovex.de> > --- Hi Anna-Lena, Thanks for your patch. > +INSANE_SKIP:${MLPREFIX}lib${BPN} = "useless-rpaths" I believe this check is not allowed to be skipped. The yocto-check-layer script is not happy about this line: Parsing recipes...ERROR: /srv/pokybuild/yocto-worker/check-layer/build/meta/recipes-support/sqlite/sqlite3_3.50.4.bb: QA Issue: Package libsqlite3 is skipping required QA tests. [useless-rpaths] ERROR: /srv/pokybuild/yocto-worker/check-layer/build/meta/recipes-support/sqlite/sqlite3_3.50.4.bb: Fatal QA errors were found, failing task. https://autobuilder.yoctoproject.org/valkyrie/#/builders/27/builds/2496 Can you fix this another way? Thanks, Mathieu
On Thu, Oct 02, 2025 at 01:20:35PM +0200, Mathieu Dubois-Briand via lists.openembedded.org wrote: > On Wed Oct 1, 2025 at 5:28 PM CEST, Anna-Lena Marx via lists.openembedded.org wrote: > > With the upgrade to 3.50.4, some configure options changed > > as the project switched from `autotools` to `autosetup`. > > The PACKAGECONFIG "dyn_ext" is not longer available. > > Besides, the default CONFIGUREOPTS "target", "exec_prefix" > > and "oldincludedir" became invalid. > > > > Changelog: https://sqlite.org/releaselog/3_50_4.html > > > > Signed-off-by: Anna-Lena Marx <anna-lena.marx@inovex.de> > > --- > > Hi Anna-Lena, > > Thanks for your patch. > > > +INSANE_SKIP:${MLPREFIX}lib${BPN} = "useless-rpaths" In general, adding a new INSANE_SKIP warrants a brief explanation. > I believe this check is not allowed to be skipped. The yocto-check-layer > script is not happy about this line: For additional context: https://git.openembedded.org/openembedded-core/commit/?id=ce2e42ace2d15fb6745437cf0a7f07d28398ca12 > Parsing recipes...ERROR: /srv/pokybuild/yocto-worker/check-layer/build/meta/recipes-support/sqlite/sqlite3_3.50.4.bb: QA Issue: Package libsqlite3 is skipping required QA tests. [useless-rpaths] > ERROR: /srv/pokybuild/yocto-worker/check-layer/build/meta/recipes-support/sqlite/sqlite3_3.50.4.bb: Fatal QA errors were found, failing task. > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/27/builds/2496 > > Can you fix this another way?
Am Do., 2. Okt. 2025 um 17:15 Uhr schrieb Denys Dmytriyenko <denis@denix.org>: > > In general, adding a new INSANE_SKIP warrants a brief explanation. > > > > I believe this check is not allowed to be skipped. The yocto-check-layer > > script is not happy about this line: > > For additional context: > > https://git.openembedded.org/openembedded-core/commit/?id=ce2e42ace2d15fb6745437cf0a7f07d28398ca12 > > > > Parsing recipes...ERROR: /srv/pokybuild/yocto-worker/check-layer/build/meta/recipes-support/sqlite/sqlite3_3.50.4.bb: QA Issue: Package libsqlite3 is skipping required QA tests. [useless-rpaths] > > ERROR: /srv/pokybuild/yocto-worker/check-layer/build/meta/recipes-support/sqlite/sqlite3_3.50.4.bb: Fatal QA errors were found, failing task. > > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/27/builds/2496 > > > > Can you fix this another way? I just sent another patch version solving the issue differently, but it's probably worth answering again here. sqlite3 has no option to disable rpath in the current version. There is some code preparing it, but it's commented and not yet ready to use - thus the hacky patch with status "pending". The sqlite user forum states that the `--disable-rpath` flag will be reintroduced in 3.51 again: https://sqlite.org/forum/forumpost/be3b253ddadaa9f16a9b42c41c85701ae56811159a36535ff5ee7c6c44c1ea63 Please feel free to suggest a better suitable upstream status. Anna
On Thu, 2 Oct 2025 at 17:34, Anna-Lena Marx <anna-lena.marx@inovex.de> wrote: > I just sent another patch version solving the issue differently, but > it's probably worth answering again here. > > sqlite3 has no option to disable rpath in the current version. There > is some code preparing it, but it's commented and not yet ready to use > - thus the hacky patch with status "pending". > The sqlite user forum states that the `--disable-rpath` flag will be > reintroduced in 3.51 again: > https://sqlite.org/forum/forumpost/be3b253ddadaa9f16a9b42c41c85701ae56811159a36535ff5ee7c6c44c1ea63 > Please feel free to suggest a better suitable upstream status. That forum post actually refers to an upstream commit that does the re-introduction, so it's much better to backport that and use upstream-status: Backport [link]. Alex
diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc index 28a33282ae..8b1d3b1528 100644 --- a/meta/recipes-support/sqlite/sqlite3.inc +++ b/meta/recipes-support/sqlite/sqlite3.inc @@ -23,8 +23,8 @@ CVE_PRODUCT = "sqlite" inherit autotools pkgconfig siteinfo # enable those which are enabled by default in configure -PACKAGECONFIG ?= "fts4 fts5 rtree dyn_ext" -PACKAGECONFIG:class-native ?= "fts4 fts5 rtree dyn_ext" +PACKAGECONFIG ?= "fts4 fts5 rtree" +PACKAGECONFIG:class-native ?= "fts4 fts5 rtree" PACKAGECONFIG[editline] = "--enable-editline,--disable-editline,libedit" PACKAGECONFIG[readline] = "--enable-readline,--disable-readline,readline ncurses" @@ -33,15 +33,21 @@ PACKAGECONFIG[fts4] = "--enable-fts4,--disable-fts4" PACKAGECONFIG[fts5] = "--enable-fts5,--disable-fts5" PACKAGECONFIG[rtree] = "--enable-rtree,--disable-rtree" PACKAGECONFIG[session] = "--enable-session,--disable-session" -PACKAGECONFIG[dyn_ext] = "--enable-dynamic-extensions,--disable-dynamic-extensions" PACKAGECONFIG[zlib] = ",,zlib" CACHED_CONFIGUREVARS += "${@bb.utils.contains('PACKAGECONFIG', 'zlib', '', 'ac_cv_search_deflate=no',d)}" +# The configure options target, exec_prefix and oldincludedir +# are not supported by sqlite3 anymore. +CONFIGUREOPTS:remove = "--target=${TARGET_SYS}" +CONFIGUREOPTS:remove = "--exec_prefix=${exec_prefix}" +CONFIGUREOPTS:remove = "--oldincludedir=${includedir}" + EXTRA_OECONF = " \ --enable-shared \ --enable-threadsafe \ --disable-static-shell \ + --soname=legacy \ " # pread() is in POSIX.1-2001 so any reasonable system must surely support it @@ -51,7 +57,7 @@ CFLAGS += "-DUSE_PREAD" CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA" # Unless SQLITE_BYTEORDER is predefined, the code falls back to build time -# huristics, which are not always correct +# heuristics, which are not always correct CFLAGS += "${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'le', '-DSQLITE_BYTEORDER=1234', '-DSQLITE_BYTEORDER=4321', d)}" PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}" @@ -66,3 +72,5 @@ FILES:lib${BPN}-staticdev = "${libdir}/lib*.a" AUTO_LIBNAME_PKGS = "${MLPREFIX}lib${BPN}" BBCLASSEXTEND = "native nativesdk" + +INSANE_SKIP:${MLPREFIX}lib${BPN} = "useless-rpaths" diff --git a/meta/recipes-support/sqlite/sqlite3_3.48.0.bb b/meta/recipes-support/sqlite/sqlite3_3.50.4.bb similarity index 69% rename from meta/recipes-support/sqlite/sqlite3_3.48.0.bb rename to meta/recipes-support/sqlite/sqlite3_3.50.4.bb index bd2ac6614d..073f7510c7 100644 --- a/meta/recipes-support/sqlite/sqlite3_3.48.0.bb +++ b/meta/recipes-support/sqlite/sqlite3_3.50.4.bb @@ -4,5 +4,5 @@ LICENSE = "PD" LIC_FILES_CHKSUM = "file://sqlite3.h;endline=11;md5=786d3dc581eff03f4fd9e4a77ed00c66" SRC_URI = "http://www.sqlite.org/2025/sqlite-autoconf-${SQLITE_PV}.tar.gz" -SRC_URI[sha256sum] = "ac992f7fca3989de7ed1fe99c16363f848794c8c32a158dafd4eb927a2e02fd5" +SRC_URI[sha256sum] = "a3db587a1b92ee5ddac2f66b3edb41b26f9c867275782d46c3a088977d6a5b18"
With the upgrade to 3.50.4, some configure options changed as the project switched from `autotools` to `autosetup`. The PACKAGECONFIG "dyn_ext" is not longer available. Besides, the default CONFIGUREOPTS "target", "exec_prefix" and "oldincludedir" became invalid. Changelog: https://sqlite.org/releaselog/3_50_4.html Signed-off-by: Anna-Lena Marx <anna-lena.marx@inovex.de> --- meta/recipes-support/sqlite/sqlite3.inc | 16 ++++++++++++---- .../{sqlite3_3.48.0.bb => sqlite3_3.50.4.bb} | 2 +- 2 files changed, 13 insertions(+), 5 deletions(-) rename meta/recipes-support/sqlite/{sqlite3_3.48.0.bb => sqlite3_3.50.4.bb} (69%)