diff mbox series

[v4,7/7] clang: no need to install tblgen binaries in nativesdk-clang

Message ID 20250924120834.2886320-7-ross.burton@arm.com
State Accepted, archived
Commit c79837a11ccf0f3e5a8ccab4ffb379cdefe482e8
Headers show
Series [v4,1/7] clang: improve opt-viewer PACKAGECONFIG | expand

Commit Message

Ross Burton Sept. 24, 2025, 12:08 p.m. UTC
These are only needed if cross-compiling clang, and if someone is
cross-compiling clang in a SDK they should build their own binaries as
these ones might not match the version of clang they're building.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-devtools/clang/clang_git.bb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Khem Raj Sept. 24, 2025, 8:05 p.m. UTC | #1
On 9/24/25 5:08 AM, Ross Burton via lists.openembedded.org wrote:
> These are only needed if cross-compiling clang, and if someone is
> cross-compiling clang in a SDK they should build their own binaries as
> these ones might not match the version of clang they're building.
> 

yeah it perhaps makes sense, I had a test where I will build clang 
itself using SDK for target, this is only useful for compiler developers
and thats a small subset of users, moreover they do not use OE SDKs for
development.

> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>   meta/recipes-devtools/clang/clang_git.bb | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/recipes-devtools/clang/clang_git.bb b/meta/recipes-devtools/clang/clang_git.bb
> index 9ccb81a5308..53bca1c24f8 100644
> --- a/meta/recipes-devtools/clang/clang_git.bb
> +++ b/meta/recipes-devtools/clang/clang_git.bb
> @@ -222,13 +222,11 @@ do_install:append:class-nativesdk () {
>       if ${@bb.utils.contains('PACKAGECONFIG', 'clangd', 'true', 'false', d)}; then
>           install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clangd-indexer ${D}${bindir}/clangd-indexer
>       fi
> -    install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clang-tblgen ${D}${bindir}/clang-tblgen
> +
>       for f in `find ${D}${bindir} -executable -type f -not -type l`; do
>           test -n "`file -b $f|grep -i ELF`" && ${STRIP} $f
>       done
> -    ln -sf clang-tblgen ${D}${bindir}/clang-tblgen${PV}
> -    ln -sf llvm-tblgen ${D}${bindir}/llvm-tblgen${PV}
> -    ln -sf llvm-config ${D}${bindir}/llvm-config${PV}
> +
>       rm -rf ${D}${datadir}/llvm/cmake
>       rm -rf ${D}${datadir}/llvm
>   
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#223973): https://lists.openembedded.org/g/openembedded-core/message/223973
> Mute This Topic: https://lists.openembedded.org/mt/115410451/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-devtools/clang/clang_git.bb b/meta/recipes-devtools/clang/clang_git.bb
index 9ccb81a5308..53bca1c24f8 100644
--- a/meta/recipes-devtools/clang/clang_git.bb
+++ b/meta/recipes-devtools/clang/clang_git.bb
@@ -222,13 +222,11 @@  do_install:append:class-nativesdk () {
     if ${@bb.utils.contains('PACKAGECONFIG', 'clangd', 'true', 'false', d)}; then
         install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clangd-indexer ${D}${bindir}/clangd-indexer
     fi
-    install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clang-tblgen ${D}${bindir}/clang-tblgen
+
     for f in `find ${D}${bindir} -executable -type f -not -type l`; do
         test -n "`file -b $f|grep -i ELF`" && ${STRIP} $f
     done
-    ln -sf clang-tblgen ${D}${bindir}/clang-tblgen${PV}
-    ln -sf llvm-tblgen ${D}${bindir}/llvm-tblgen${PV}
-    ln -sf llvm-config ${D}${bindir}/llvm-config${PV}
+
     rm -rf ${D}${datadir}/llvm/cmake
     rm -rf ${D}${datadir}/llvm