diff mbox series

systemd: backport fix for handle USE_NLS from master

Message ID 20250918134710.1170816-1-emailaddress.ashish@gmail.com
State New
Headers show
Series systemd: backport fix for handle USE_NLS from master | expand

Commit Message

Ashish Mishra Sept. 18, 2025, 1:47 p.m. UTC
From: AshishKumar Mishra <emailaddress.ashish@gmail.com>

Do not build translations when NLS is disabled.
(From OE-Core rev: 83795ef6c3fa12a863cd20b7ec1a2607606987b6)

This change corresponds to upstream d848b454e64ffbd642590b4bbc378619e1547ad3
from master .
Since the systemd version are different between master & scarthgap
applied the patch manually

Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: AshishKumar Mishra <emailaddress.ashish@gmail.com>
---
 meta/recipes-core/systemd/systemd_255.21.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Gyorgy Sarvari Sept. 18, 2025, 2:27 p.m. UTC | #1
This backport looks useful, but could you please resend it with the
correct subject? If it doesn't contain the target branch name, possibly
the maintainer is going to miss it. You can find into about this in the
docs[1], just at the bottom of section 4.7.

Also, please keep the patch on the openembedded-core@ mailing list, the
patch will find the target audience here.

[1]:
https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html#submitting-changes-to-stable-release-branches

On 9/18/25 15:47, Ashish Mishra via lists.yoctoproject.org wrote:
> From: AshishKumar Mishra <emailaddress.ashish@gmail.com>
>
> Do not build translations when NLS is disabled.
> (From OE-Core rev: 83795ef6c3fa12a863cd20b7ec1a2607606987b6)
>
> This change corresponds to upstream d848b454e64ffbd642590b4bbc378619e1547ad3
> from master .
> Since the systemd version are different between master & scarthgap
> applied the patch manually
>
> Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: AshishKumar Mishra <emailaddress.ashish@gmail.com>
> ---
>  meta/recipes-core/systemd/systemd_255.21.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd_255.21.bb b/meta/recipes-core/systemd/systemd_255.21.bb
> index e866f9921b..87e186bbfa 100644
> --- a/meta/recipes-core/systemd/systemd_255.21.bb
> +++ b/meta/recipes-core/systemd/systemd_255.21.bb
> @@ -247,6 +247,7 @@ EXTRA_OEMESON += "-Dnobody-user=nobody \
>                    -Dmode=release \
>                    -Dsystem-alloc-uid-min=101 \
>                    -Dsystem-uid-max=999 \
> +                  -Dtranslations=${@'false' if d.getVar('USE_NLS') == 'no' else 'true'} \
>                    -Dsystem-alloc-gid-min=101 \
>                    -Dsystem-gid-max=999 \
>                    ${@bb.utils.contains('DISTRO_FEATURES', 'zeroconf', '-Ddefault-mdns=no -Ddefault-llmnr=no', '', d)} \
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#65858): https://lists.yoctoproject.org/g/yocto/message/65858
> Mute This Topic: https://lists.yoctoproject.org/mt/115310188/6084445
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Ashish Mishra Sept. 18, 2025, 3:54 p.m. UTC | #2
Thanks for feedback @Gyorgy Sarvari

I have pushed the change https://lists.openembedded.org/g/openembedded-core/message/223646

Sorry if i may ask :
1) As process since i have send the change , should i delete this thread
2) Whats the suggested way to do handle such correction (no change in patch nut just added missed branch  details )
3) I will monitor scarthgap branch as suggested ,
is there any other way to know if the patch is accepted or some other modification is expected by maintainer

Just trying to create an mental process so do less mistake mistake
I will share two more patches once this goes through

Thanks Again .
Gyorgy Sarvari Sept. 18, 2025, 6:03 p.m. UTC | #3
On 9/18/25 17:54, Ashish Mishra via lists.openembedded.org wrote:
> Thanks for feedback @Gyorgy Sarvari 
>
> I have pushed the change
> https://lists.openembedded.org/g/openembedded-core/message/223646 
>  
> Sorry if i may ask :
> 1) As process since i have send the change , should i delete this thread 

You don't have to delete it, it will be just ignored in this case.

> 2) Whats the suggested way to do handle such correction (no change in
> patch nut just added missed branch  details ) 

If you notice it on your own, you can just send a reply to your own
initial patch noting that it was a mistake, and send the correct one
afterwards. It happens.

> 3) I will monitor scarthgap branch as suggested ,
>     is there any other way to know if the patch is accepted or some
> other modification is expected by maintainer 

If any modification is expected, you will get a response directly to the
patch. Steve Sakoman (the the maintainer of the stable branches) sends
out regularly patch reviews on this ML, that includes a list of patches
that he intends to accept. Look for that mail.

>  
> Just trying to create an mental process so do less mistake mistake     
> I will share two more patches once this goes through 
>  
> Thanks Again .
>  
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#223648): https://lists.openembedded.org/g/openembedded-core/message/223648
> Mute This Topic: https://lists.openembedded.org/mt/115310928/6084445
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-core/systemd/systemd_255.21.bb b/meta/recipes-core/systemd/systemd_255.21.bb
index e866f9921b..87e186bbfa 100644
--- a/meta/recipes-core/systemd/systemd_255.21.bb
+++ b/meta/recipes-core/systemd/systemd_255.21.bb
@@ -247,6 +247,7 @@  EXTRA_OEMESON += "-Dnobody-user=nobody \
                   -Dmode=release \
                   -Dsystem-alloc-uid-min=101 \
                   -Dsystem-uid-max=999 \
+                  -Dtranslations=${@'false' if d.getVar('USE_NLS') == 'no' else 'true'} \
                   -Dsystem-alloc-gid-min=101 \
                   -Dsystem-gid-max=999 \
                   ${@bb.utils.contains('DISTRO_FEATURES', 'zeroconf', '-Ddefault-mdns=no -Ddefault-llmnr=no', '', d)} \