Message ID | 20250916155800.3860178-1-f_l_k@t-online.de |
---|---|
State | New |
Headers | show |
Series | [1/2] introduce virtual/ffmpeg | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/1-2-introduce-virtual-ffmpeg.patch FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
On Tue, 16 Sept 2025 at 17:58, Markus Volk via lists.openembedded.org <f_l_k=t-online.de@lists.openembedded.org> wrote: > - add 'ffmpeg' as the preferred provider for virtual/ffmpeg > > Using virtual/ffmpeg can be useful for recipes that require a different version > to that provided by oe-core (e.g. kodi) This needs more detail. What else would be providing virtual/ffmpeg, other than ffmpeg itself? Why the justification is talking about 'different versions', and not different providers? Alex
On Tue, Sep 16 2025 at 18:26:32 +02:00:00, Alexander Kanavin <alex.kanavin@gmail.com> wrote: > This needs more detail. What else would be providing virtual/ffmpeg, > other than ffmpeg itself? Why the justification is talking about > 'different versions', and not different providers? I was talking about versions, because thats what I use it for. A different provider would be e.g libav,but in meta-kodi I have older versions of ffmpeg called ffmpeg-6 and ffmpeg-7 and let them provide virtual/ffmpeg. Dont ask me why I didn't stick with preferred_version. I only remember that I had issues with using it but not exactly what it was. But if you think this is the way it should be, I can give it another try
I think that was because I had to build Kodi and mpv with different ffmpeg versions at the time, because mpv was updated to ffmpeg 7 but Kodi wasn't ready yet. Similar situation like today with ffmpeg 8. There exists a patch to add ffmpeg 8 support in kodi but to me it feels like its a bit to early for this step. couldn't find a way to use two different system versions of ffmpeg as long as they only differed in the version number. > I only remember that I had issues with using it but not exactly what > it was.
diff --git a/meta/conf/distro/include/default-providers.inc b/meta/conf/distro/include/default-providers.inc index 3f113543cd..7c969b0889 100644 --- a/meta/conf/distro/include/default-providers.inc +++ b/meta/conf/distro/include/default-providers.inc @@ -13,6 +13,7 @@ PREFERRED_PROVIDER_virtual/nativesdk-libgl ?= "${@bb.utils.contains('DISTRO_FEAT PREFERRED_PROVIDER_virtual/libgles1 ?= "${@bb.utils.contains('DISTRO_FEATURES', 'glvnd', 'libglvnd', 'mesa',d)}" PREFERRED_PROVIDER_virtual/libgles2 ?= "${@bb.utils.contains('DISTRO_FEATURES', 'glvnd', 'libglvnd', 'mesa',d)}" PREFERRED_PROVIDER_virtual/libgles3 ?= "${@bb.utils.contains('DISTRO_FEATURES', 'glvnd', 'libglvnd', 'mesa',d)}" +PREFERRED_PROVIDER_virtual/ffmpeg ?= "ffmpeg" PREFERRED_PROVIDER_virtual/mesa ?= "mesa" PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg-utils" PREFERRED_PROVIDER_virtual/update-alternatives-native ?= "opkg-utils-native"
- add 'ffmpeg' as the preferred provider for virtual/ffmpeg Using virtual/ffmpeg can be useful for recipes that require a different version to that provided by oe-core (e.g. kodi) Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta/conf/distro/include/default-providers.inc | 1 + 1 file changed, 1 insertion(+)