diff mbox series

Fixes [YOCTO #15965]

Message ID 20250916122517.1965-1-barne.carstensen@danfoss.com
State New
Headers show
Series Fixes [YOCTO #15965] | expand

Commit Message

Barne Carstensen Sept. 16, 2025, 12:25 p.m. UTC
Copy all the parselogs-ignores file so that they are always packed into the testexport.tar.gz (even when testsuite parselog is not selected)

Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
CC: randy.macleod@windriver.com
---
 meta/classes-recipe/testexport.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

patchtest@automation.yoctoproject.org Sept. 16, 2025, 12:30 p.m. UTC | #1
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/Fixes-YOCTO-15965.patch

FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format)

PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!
Mikko Rapeli Sept. 16, 2025, 1:09 p.m. UTC | #2
Hi,

This is not for master branch and subject line should be
something like "[branch name][PATCH] testexport.bbclass: always capture ignore files"

On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> Copy all the parselogs-ignores file so that they are always packed into the testexport.tar.gz (even when testsuite parselog is not selected)
> 
> Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> CC: randy.macleod@windriver.com
> ---
>  meta/classes-recipe/testexport.bbclass | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/classes-recipe/testexport.bbclass b/meta/classes-recipe/testexport.bbclass
> index 843d777e3b..2f473a8811 100644
> --- a/meta/classes-recipe/testexport.bbclass
> +++ b/meta/classes-recipe/testexport.bbclass
> @@ -79,6 +79,7 @@ def testexport_main(d):
>  def copy_needed_files(d, tc):
>      import shutil
>      import oe.path
> +    import glob
>  
>      from oeqa.utils.package_manager import _get_json_file
>      from oeqa.core.utils.test import getSuiteCasesFiles
> @@ -120,6 +121,11 @@ def copy_needed_files(d, tc):
>                      oe.path.copytree(src, dst)
>                  else:
>                      shutil.copy2(src, dst)
> +    
> +    # Copy all parselogs-ignores files
> +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> +    for f in parselogs_ignores:
> +         shutil.copy2(f, cases_path)

Master branch is quite different. There the tests and their data
files are now copied from all enabled layers, not just core.
So I would rather port those fixes to relevant branches to avoid
duplicating maitenance.

Cheers,

-Mikko

>      # Copy test data
>      image_name = ("%s/%s" % (d.getVar('DEPLOY_DIR_IMAGE'),

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#223546): https://lists.openembedded.org/g/openembedded-core/message/223546
> Mute This Topic: https://lists.openembedded.org/mt/115271587/7159507
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mikko.rapeli@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Mikko Rapeli Sept. 16, 2025, 1:41 p.m. UTC | #3
Hi,

On Tue, Sep 16, 2025 at 04:09:58PM +0300, Mikko Rapeli via lists.openembedded.org wrote:
> This is not for master branch and subject line should be
> something like "[branch name][PATCH] testexport.bbclass: always capture ignore files"
> 
> On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> > Copy all the parselogs-ignores file so that they are always packed into the testexport.tar.gz (even when testsuite parselog is not selected)
> > 
> > Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> > CC: randy.macleod@windriver.com
> > ---
> >  meta/classes-recipe/testexport.bbclass | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/meta/classes-recipe/testexport.bbclass b/meta/classes-recipe/testexport.bbclass
> > index 843d777e3b..2f473a8811 100644
> > --- a/meta/classes-recipe/testexport.bbclass
> > +++ b/meta/classes-recipe/testexport.bbclass
> > @@ -79,6 +79,7 @@ def testexport_main(d):
> >  def copy_needed_files(d, tc):
> >      import shutil
> >      import oe.path
> > +    import glob
> >  
> >      from oeqa.utils.package_manager import _get_json_file
> >      from oeqa.core.utils.test import getSuiteCasesFiles
> > @@ -120,6 +121,11 @@ def copy_needed_files(d, tc):
> >                      oe.path.copytree(src, dst)
> >                  else:
> >                      shutil.copy2(src, dst)
> > +    
> > +    # Copy all parselogs-ignores files
> > +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> > +    for f in parselogs_ignores:
> > +         shutil.copy2(f, cases_path)
> 
> Master branch is quite different. There the tests and their data
> files are now copied from all enabled layers, not just core.
> So I would rather port those fixes to relevant branches to avoid
> duplicating maitenance.

Since the commits are bit scattered, these from master branch
would be needed if not already in the relevant branch:

e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers
05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
2d900c3061e12 oeqa/runtime: set self.runner and handle None

Cheers,

-Mikko
diff mbox series

Patch

diff --git a/meta/classes-recipe/testexport.bbclass b/meta/classes-recipe/testexport.bbclass
index 843d777e3b..2f473a8811 100644
--- a/meta/classes-recipe/testexport.bbclass
+++ b/meta/classes-recipe/testexport.bbclass
@@ -79,6 +79,7 @@  def testexport_main(d):
 def copy_needed_files(d, tc):
     import shutil
     import oe.path
+    import glob
 
     from oeqa.utils.package_manager import _get_json_file
     from oeqa.core.utils.test import getSuiteCasesFiles
@@ -120,6 +121,11 @@  def copy_needed_files(d, tc):
                     oe.path.copytree(src, dst)
                 else:
                     shutil.copy2(src, dst)
+    
+    # Copy all parselogs-ignores files
+    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
+    for f in parselogs_ignores:
+         shutil.copy2(f, cases_path)
 
     # Copy test data
     image_name = ("%s/%s" % (d.getVar('DEPLOY_DIR_IMAGE'),