| Message ID | 20250909112448.2811932-1-koen.kooi@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | systemd: change pni-names logic to something less confusing | expand |
diff --git a/meta/recipes-core/systemd/systemd_257.8.bb b/meta/recipes-core/systemd/systemd_257.8.bb index 6399c57640..549eb7fb29 100644 --- a/meta/recipes-core/systemd/systemd_257.8.bb +++ b/meta/recipes-core/systemd/systemd_257.8.bb @@ -401,7 +401,7 @@ do_install() { fi # Actively disable Predictable Network Interface Names - if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then + if ! ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d)}; then sed -i 's/^NamePolicy=.*/NamePolicy=/;s/^AlternativeNamesPolicy=.*/AlternativeNamesPolicy=/' ${D}${nonarch_libdir}/systemd/network/99-default.link fi }
Using bb.utils.contains in negative logic leads to either overly verbose or plain confusing code, so harness the power of Ross and Antonin to make this less verbose and slightly clearer. This moves the negative logic from the inline python ('true if not') to bash ('if !'). Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com> --- meta/recipes-core/systemd/systemd_257.8.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)