| Message ID | 20250905202812.403790-1-skandigraun@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | rust-target-config.bbclass: move target generation before do_configure | expand |
diff --git a/meta/classes-recipe/rust-target-config.bbclass b/meta/classes-recipe/rust-target-config.bbclass index 8ab5317c3f..7b238c1840 100644 --- a/meta/classes-recipe/rust-target-config.bbclass +++ b/meta/classes-recipe/rust-target-config.bbclass @@ -442,7 +442,7 @@ python do_rust_gen_targets () { rust_gen_target(d, 'TARGET', wd, d.getVar('TARGET_ARCH')) } -addtask rust_gen_targets after do_patch before do_compile +addtask rust_gen_targets after do_patch before do_configure do_rust_gen_targets[dirs] += "${RUST_TARGETS_DIR}" # For building target C dependecies use only compiler parameters defined in OE
The rust_get_targets task from the rust-target-config class generates some Rust compiler configurations for different the target and host machine, which is used by Rust during compiling a recipe. These configurations supposed to be available by the time the Rust compiler is used for the first time. By default, this task is executed "before do_compile" - it assumes that this is the first task that would use this configuration. However this is not always the case, especially with projects which are not pure Cargo projects, rather Cargo/Rust is called by a different build system. As an example librsvg uses meson, and during the do_configure step Meson probes the Rust compiler, trying to gather some library info from Rust. In case the rust_gen_targets task was executed before the do_configure task, then everything works. However this is not always the case - sometimes the job is executed between the configure and compile steps, in which case the configuration fails. To avoid such problems, generate these targets before the do_configure step. Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com> --- Alternatively I believe I could also do some deltask + addtask combo in the librsvg recipe to reorder the tasks, however I haven't seen other recipes doing that in oe-core. meta/classes-recipe/rust-target-config.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)