| Message ID | 20250905154447.2710516-1-skandigraun@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ptest-cargo.bbclass: sort binaries for reproducibility | expand |
diff --git a/meta/classes-recipe/ptest-cargo.bbclass b/meta/classes-recipe/ptest-cargo.bbclass index 8351644b0f..30463e117b 100644 --- a/meta/classes-recipe/ptest-cargo.bbclass +++ b/meta/classes-recipe/ptest-cargo.bbclass @@ -70,7 +70,7 @@ python do_compile_ptest_cargo() { cargo_test_binaries_file = d.getVar('CARGO_TEST_BINARIES_FILES') bb.note(f"Found {len(test_bins)} tests, write their paths into {cargo_test_binaries_file}") with open(cargo_test_binaries_file, "w") as f: - for test_bin in test_bins: + for test_bin in sorted(test_bins): f.write(f"{test_bin}\n") }
When compiling tests with cargo, the produced binaries are created in a non-deterministic order. The list of binaries themselves are taken from some of the log info produced by cargo, which contains them in the order as they were created. The class later writes this list of binaries in the run-ptest script in the order that it found them. In case the test suite contains more than 1 or 2 binaries, then the order of these binaries is different almost each run, making the resulting ptest package non-reproducible. To avoid this, sort the list of test binaries before storing them. Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com> --- meta/classes-recipe/ptest-cargo.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)