diff mbox series

python: Correct the upstream status in NODEV patch

Message ID 20250902022119.3497724-1-raj.khem@gmail.com
State New
Headers show
Series python: Correct the upstream status in NODEV patch | expand

Commit Message

Khem Raj Sept. 2, 2025, 2:21 a.m. UTC
Ensure it is reflecting correct information and status of patch

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../python/python3/test_posix_nodev_disable.patch           | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Ross Burton Sept. 4, 2025, 12:21 p.m. UTC | #1
On 2 Sep 2025, at 03:21, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> 
> Ensure it is reflecting correct information and status of patch
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> .../python/python3/test_posix_nodev_disable.patch           | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch b/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
> index 85767e1e898..df60302520e 100644
> --- a/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
> +++ b/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
> @@ -1,7 +1,11 @@
> Disable part of test_posix.test_makedev that depends on the NODEV
> macro being defined (missing on musl).
> 
> -Upstream-Status: Submitted [https://github.com/python/cpython/pull/31794]
> +See https://github.com/python/cpython/pull/31794 where NODEV
> +handling is introduced.
> +
> +Upstream-Status: Inappropriate [Musl-Specific]

Can you file at least a ticket for the issue that the tests don’t work on musl?  (I see that alpine also has this patch)

Ross
Khem Raj Sept. 4, 2025, 5:35 p.m. UTC | #2
On Thu, Sep 4, 2025 at 5:22 AM Ross Burton <Ross.Burton@arm.com> wrote:
>
> On 2 Sep 2025, at 03:21, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> >
> > Ensure it is reflecting correct information and status of patch
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > .../python/python3/test_posix_nodev_disable.patch           | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch b/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
> > index 85767e1e898..df60302520e 100644
> > --- a/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
> > +++ b/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
> > @@ -1,7 +1,11 @@
> > Disable part of test_posix.test_makedev that depends on the NODEV
> > macro being defined (missing on musl).
> >
> > -Upstream-Status: Submitted [https://github.com/python/cpython/pull/31794]
> > +See https://github.com/python/cpython/pull/31794 where NODEV
> > +handling is introduced.
> > +
> > +Upstream-Status: Inappropriate [Musl-Specific]
>
> Can you file at least a ticket for the issue that the tests don’t work on musl?  (I see that alpine also has this patch)
>

right, I have already added to the issue which caused the problem,
hopefully that is a better place to call it out.

https://github.com/python/cpython/pull/31794#discussion_r2314773987

> Ross
Alexander Kanavin Sept. 5, 2025, 10:37 a.m. UTC | #3
On Thu, 4 Sept 2025 at 19:35, Khem Raj via lists.openembedded.org
<raj.khem=gmail.com@lists.openembedded.org> wrote:
> right, I have already added to the issue which caused the problem,
> hopefully that is a better place to call it out.
>
> https://github.com/python/cpython/pull/31794#discussion_r2314773987

I disagree. That pull request is already merged, and so it's far too
easy to ignore or miss the report. This warrants its own ticket.

Alex
diff mbox series

Patch

diff --git a/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch b/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
index 85767e1e898..df60302520e 100644
--- a/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
+++ b/meta/recipes-devtools/python/python3/test_posix_nodev_disable.patch
@@ -1,7 +1,11 @@ 
 Disable part of test_posix.test_makedev that depends on the NODEV
 macro being defined (missing on musl).
 
-Upstream-Status: Submitted [https://github.com/python/cpython/pull/31794]
+See https://github.com/python/cpython/pull/31794 where NODEV
+handling is introduced.
+
+Upstream-Status: Inappropriate [Musl-Specific]
+
 Signed-off-by: Khem Raj <raj.khem@gmail.com>
 --- a/Lib/test/test_posix.py
 +++ b/Lib/test/test_posix.py