| Message ID | 20250828091630.82819-1-jon.mason@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] runqemu: remove setting of mem on kernel command line for certain systems | expand |
On Mon, Sep 1, 2025 at 2:45 PM Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote: > > On 28 Aug 2025, at 10:16, Jon Mason via lists.openembedded.org <jon.mason=arm.com@lists.openembedded.org> wrote: > > > > Some emulated hardware will not boot if mem is set on the kernel command > > line. Also, it is not necessary if the device tree file, as that > > _should_ have the memory size specified in it. Add a check for QB_DTB > > and don't set it if specified. > > Can you elaborate on “some” so this can be verified or tested in the future? The machines in question are the QEMU emulated Raspberry Pis, all of them. Given the amount of time since I originally sent this, I'll resend the series with a modified comment saying this. Also, I managed to mess up the intended mailing list (but it magically landed there somehow). So, another reason to resend. Thanks, Jon > > Ross > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#222676): https://lists.openembedded.org/g/openembedded-core/message/222676 > Mute This Topic: https://lists.openembedded.org/mt/114931906/3616920 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [jdmason@kudzu.us] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/scripts/runqemu b/scripts/runqemu index c24528eac80e..16982bbc6b73 100755 --- a/scripts/runqemu +++ b/scripts/runqemu @@ -883,7 +883,7 @@ to your build configuration. self.set('QB_MEM', qb_mem) mach = self.get('MACHINE') - if not mach.startswith(('qemumips', 'qemux86', 'qemuloongarch64')): + if not mach.startswith(('qemumips', 'qemux86', 'qemuloongarch64')) and self.get('QB_DTB') == "": self.kernel_cmdline_script += ' mem=%s' % self.get('QB_MEM').replace('-m','').strip() + 'M' self.qemu_opt_script += ' %s' % self.get('QB_MEM')
Some emulated hardware will not boot if mem is set on the kernel command line. Also, it is not necessary if the device tree file, as that _should_ have the memory size specified in it. Add a check for QB_DTB and don't set it if specified. Signed-off-by: Jon Mason <jon.mason@arm.com> --- scripts/runqemu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)