| Message ID | 20250825133004.3154972-1-perxjoh@axis.com |
|---|---|
| State | Accepted, archived |
| Commit | 18a87dd1724e0934a669aefae36d20374c06c493 |
| Headers | show |
| Series | rust-target-config: Add has-thread-local option | expand |
Cc Steve for backport to stable releases? The introducing commit goes back to langdale so backporting to scarthgap and walnascar would make sense to me? @Per x Johansson/@Steve, what do you think? Cheers, Quentin On 8/25/25 3:30 PM, Per x Johansson via lists.openembedded.org wrote: > [You don't often get email from perxjoh=axis.com@lists.openembedded.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > The "has-elf-tls" option was removed by the commit > 8e1614a906086fb46c5dd7b7f2dffab91194165c. However is should have been > renamed to "has-thread-local", since it was renamed and not removed in > rust by this commit. > https://github.com/rust-lang/rust/commit/391332c5d9d5a5e97a0d36e011a87ad43045cfd3 > > Change-Id: Ia1fdf7698ebeef62a88052713645d5b499164353 > Signed-off-by: Per x Johansson <perxjoh@axis.com> > --- > meta/classes-recipe/rust-target-config.bbclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/classes-recipe/rust-target-config.bbclass b/meta/classes-recipe/rust-target-config.bbclass > index cac6e90a9e..0df6f0904c 100644 > --- a/meta/classes-recipe/rust-target-config.bbclass > +++ b/meta/classes-recipe/rust-target-config.bbclass > @@ -418,6 +418,7 @@ def rust_gen_target(d, thing, wd, arch): > tspec['linker-is-gnu'] = True > tspec['linker-flavor'] = "gcc" > tspec['has-rpath'] = True > + tspec['has-thread-local'] = True > tspec['position-independent-executables'] = True > tspec['panic-strategy'] = d.getVar("RUST_PANIC_STRATEGY") > > -- > 2.39.5 > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#222407): https://lists.openembedded.org/g/openembedded-core/message/222407 > Mute This Topic: https://lists.openembedded.org/mt/114881321/6293953 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [quentin.schulz@cherry.de] > -=-=-=-=-=-=-=-=-=-=-=- >
This started to cause trouble for us after the upgrade to walnascar with Rust 1.84.1 which included this commit https://github.com/rust-lang/rust/commit/d868fdce6b9ddef6abcc8de86b3ba8459def36a2. So I think that it should atlest go into walnascar. /Per
diff --git a/meta/classes-recipe/rust-target-config.bbclass b/meta/classes-recipe/rust-target-config.bbclass index cac6e90a9e..0df6f0904c 100644 --- a/meta/classes-recipe/rust-target-config.bbclass +++ b/meta/classes-recipe/rust-target-config.bbclass @@ -418,6 +418,7 @@ def rust_gen_target(d, thing, wd, arch): tspec['linker-is-gnu'] = True tspec['linker-flavor'] = "gcc" tspec['has-rpath'] = True + tspec['has-thread-local'] = True tspec['position-independent-executables'] = True tspec['panic-strategy'] = d.getVar("RUST_PANIC_STRATEGY")
The "has-elf-tls" option was removed by the commit 8e1614a906086fb46c5dd7b7f2dffab91194165c. However is should have been renamed to "has-thread-local", since it was renamed and not removed in rust by this commit. https://github.com/rust-lang/rust/commit/391332c5d9d5a5e97a0d36e011a87ad43045cfd3 Change-Id: Ia1fdf7698ebeef62a88052713645d5b499164353 Signed-off-by: Per x Johansson <perxjoh@axis.com> --- meta/classes-recipe/rust-target-config.bbclass | 1 + 1 file changed, 1 insertion(+)