| Message ID | 20250820132929.2644708-1-ross.burton@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] spirv-llvm-translator: small recipe cleanup | expand |
On Wed, Aug 20, 2025 at 6:29 AM Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote: > > - There is no need for python3native, as this recipe doesn't depend on > other python modules. > > - Inherit lib_package so the llvm-spirv binary is in a separate package > to the libLLVMSPIRVLib.so library. > > - Remove obsolete CMake options that no longer appear to be required. > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > .../spir/spirv-llvm-translator_20.1.4.bb | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb > index 64a73ce55aa..3a090b7b5cb 100644 > --- a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb > +++ b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb > @@ -15,18 +15,10 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)" > > DEPENDS = "llvm spirv-tools spirv-headers" > > -inherit cmake pkgconfig python3native > +inherit cmake pkgconfig lib_package > > -# Specify any options you want to pass to cmake using EXTRA_OECMAKE: > -# for CMAKE_SHARED_LIBS=OFF see https://github.com/KhronosGroup/SPIRV-LLVM-Translator/issues/1868 > EXTRA_OECMAKE = "\ > -DBUILD_SHARED_LIBS=ON \ > - -DCMAKE_BUILD_TYPE=Release \ Is Release already the default ? Usually this option reduces the debug info size, which may not matter for this but would be good to know. Other changes look fine. > - -DCMAKE_POSITION_INDEPENDENT_CODE=ON \ > - -DCMAKE_SKIP_RPATH=ON \ > - -DLLVM_EXTERNAL_LIT=lit \ > - -DLLVM_INCLUDE_TESTS=ON \ > - -Wno-dev \ > -DLLVM_EXTERNAL_SPIRV_HEADERS_SOURCE_DIR=${STAGING_INCDIR}/.. \ > " > > -- > 2.43.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#222179): https://lists.openembedded.org/g/openembedded-core/message/222179 > Mute This Topic: https://lists.openembedded.org/mt/114799103/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 20 Aug 2025, at 18:17, Khem Raj <raj.khem@gmail.com> wrote: > > On Wed, Aug 20, 2025 at 6:29 AM Ross Burton via lists.openembedded.org > <ross.burton=arm.com@lists.openembedded.org> wrote: >> >> - There is no need for python3native, as this recipe doesn't depend on >> other python modules. >> >> - Inherit lib_package so the llvm-spirv binary is in a separate package >> to the libLLVMSPIRVLib.so library. >> >> - Remove obsolete CMake options that no longer appear to be required. >> >> Signed-off-by: Ross Burton <ross.burton@arm.com> >> --- >> .../spir/spirv-llvm-translator_20.1.4.bb | 10 +--------- >> 1 file changed, 1 insertion(+), 9 deletions(-) >> >> diff --git a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb >> index 64a73ce55aa..3a090b7b5cb 100644 >> --- a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb >> +++ b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb >> @@ -15,18 +15,10 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)" >> >> DEPENDS = "llvm spirv-tools spirv-headers" >> >> -inherit cmake pkgconfig python3native >> +inherit cmake pkgconfig lib_package >> >> -# Specify any options you want to pass to cmake using EXTRA_OECMAKE: >> -# for CMAKE_SHARED_LIBS=OFF see https://github.com/KhronosGroup/SPIRV-LLVM-Translator/issues/1868 >> EXTRA_OECMAKE = "\ >> -DBUILD_SHARED_LIBS=ON \ >> - -DCMAKE_BUILD_TYPE=Release \ > > Is Release already the default ? Usually this option reduces the debug > info size, which may not matter > for this but would be good to know. The upstream cmakelists don’t set it either way, and changing this doesn’t change the output. (I also need to finish off the branch which makes our class pass RelWithDebInfo by default) Ross
On Wed, Aug 20, 2025 at 12:50 PM Ross Burton <Ross.Burton@arm.com> wrote: > On 20 Aug 2025, at 18:17, Khem Raj <raj.khem@gmail.com> wrote: > > > > On Wed, Aug 20, 2025 at 6:29 AM Ross Burton via lists.openembedded.org > > <ross.burton=arm.com@lists.openembedded.org> wrote: > >> > >> - There is no need for python3native, as this recipe doesn't depend on > >> other python modules. > >> > >> - Inherit lib_package so the llvm-spirv binary is in a separate package > >> to the libLLVMSPIRVLib.so library. > >> > >> - Remove obsolete CMake options that no longer appear to be required. > >> > >> Signed-off-by: Ross Burton <ross.burton@arm.com> > >> --- > >> .../spir/spirv-llvm-translator_20.1.4.bb | 10 +--------- > >> 1 file changed, 1 insertion(+), 9 deletions(-) > >> > >> diff --git a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb > b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb > >> index 64a73ce55aa..3a090b7b5cb 100644 > >> --- a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb > >> +++ b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb > >> @@ -15,18 +15,10 @@ UPSTREAM_CHECK_GITTAGREGEX = > "v(?P<pver>\d+(\.\d+)+)" > >> > >> DEPENDS = "llvm spirv-tools spirv-headers" > >> > >> -inherit cmake pkgconfig python3native > >> +inherit cmake pkgconfig lib_package > >> > >> -# Specify any options you want to pass to cmake using EXTRA_OECMAKE: > >> -# for CMAKE_SHARED_LIBS=OFF see > https://github.com/KhronosGroup/SPIRV-LLVM-Translator/issues/1868 > >> EXTRA_OECMAKE = "\ > >> -DBUILD_SHARED_LIBS=ON \ > >> - -DCMAKE_BUILD_TYPE=Release \ > > > > Is Release already the default ? Usually this option reduces the debug > > info size, which may not matter > > for this but would be good to know. > > The upstream cmakelists don’t set it either way, and changing this doesn’t > change the output. > Ok > (I also need to finish off the branch which makes our class pass > RelWithDebInfo by default) > > Ross
diff --git a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb index 64a73ce55aa..3a090b7b5cb 100644 --- a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb +++ b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb @@ -15,18 +15,10 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)" DEPENDS = "llvm spirv-tools spirv-headers" -inherit cmake pkgconfig python3native +inherit cmake pkgconfig lib_package -# Specify any options you want to pass to cmake using EXTRA_OECMAKE: -# for CMAKE_SHARED_LIBS=OFF see https://github.com/KhronosGroup/SPIRV-LLVM-Translator/issues/1868 EXTRA_OECMAKE = "\ -DBUILD_SHARED_LIBS=ON \ - -DCMAKE_BUILD_TYPE=Release \ - -DCMAKE_POSITION_INDEPENDENT_CODE=ON \ - -DCMAKE_SKIP_RPATH=ON \ - -DLLVM_EXTERNAL_LIT=lit \ - -DLLVM_INCLUDE_TESTS=ON \ - -Wno-dev \ -DLLVM_EXTERNAL_SPIRV_HEADERS_SOURCE_DIR=${STAGING_INCDIR}/.. \ "
- There is no need for python3native, as this recipe doesn't depend on other python modules. - Inherit lib_package so the llvm-spirv binary is in a separate package to the libLLVMSPIRVLib.so library. - Remove obsolete CMake options that no longer appear to be required. Signed-off-by: Ross Burton <ross.burton@arm.com> --- .../spir/spirv-llvm-translator_20.1.4.bb | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)