Message ID | 20250819-mesa-libclc-panfrost-v5-1-b8b89e6af908@cherry.de |
---|---|
State | Under Review |
Headers | show |
Series | mesa: lighten up target's libclc dependencies and fix panfrost support | expand |
On Tue, Aug 19, 2025 at 1:16 AM Quentin Schulz via lists.openembedded.org <foss=0leil.net@lists.openembedded.org> wrote: > > From: Quentin Schulz <quentin.schulz@cherry.de> > > The ??= operator for PACKAGECONFIG doesn't actually do anything because > the recipe includes mesa.inc which already sets this variable (with the > = operator). > > This probably wasn't noticed until now because mesa-gl is likely only > ever built in its target flavor which was already set correctly thanks > to the :class-target override. > > This essentially only make mesa-gl-native and nativesdk-mesa-gl follow > the same configuration as the target. > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > --- > meta/recipes-graphics/mesa/mesa-gl.bb | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/meta/recipes-graphics/mesa/mesa-gl.bb b/meta/recipes-graphics/mesa/mesa-gl.bb > index e2f03c81c4588c6257ffec2892fef7fcbe9f82bf..35d6dc854cf4dfac7a757e333e25e4ddeab10b6e 100644 > --- a/meta/recipes-graphics/mesa/mesa-gl.bb > +++ b/meta/recipes-graphics/mesa/mesa-gl.bb > @@ -9,6 +9,4 @@ S = "${UNPACKDIR}/mesa-${PV}" > TARGET_CFLAGS = "-I${STAGING_INCDIR}/drm" > > # At least one DRI rendering engine is required to build mesa. > -PACKAGECONFIG ??= "opengl gallium ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}" > -PACKAGECONFIG:class-target = "opengl gallium ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}" > - > +PACKAGECONFIG = "opengl gallium ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}" you can use bb.utils.filter here e.g. ${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)} > > -- > 2.50.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#222077): https://lists.openembedded.org/g/openembedded-core/message/222077 > Mute This Topic: https://lists.openembedded.org/mt/114777987/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/recipes-graphics/mesa/mesa-gl.bb b/meta/recipes-graphics/mesa/mesa-gl.bb index e2f03c81c4588c6257ffec2892fef7fcbe9f82bf..35d6dc854cf4dfac7a757e333e25e4ddeab10b6e 100644 --- a/meta/recipes-graphics/mesa/mesa-gl.bb +++ b/meta/recipes-graphics/mesa/mesa-gl.bb @@ -9,6 +9,4 @@ S = "${UNPACKDIR}/mesa-${PV}" TARGET_CFLAGS = "-I${STAGING_INCDIR}/drm" # At least one DRI rendering engine is required to build mesa. -PACKAGECONFIG ??= "opengl gallium ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}" -PACKAGECONFIG:class-target = "opengl gallium ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}" - +PACKAGECONFIG = "opengl gallium ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"