diff mbox series

[1/4] package: Drop var-undefined QA check

Message ID 20250728095936.1495441-2-philip.lorenz@bmw.de
State New
Headers show
Series Improve handling of build qa issues | expand

Commit Message

Philip Lorenz July 28, 2025, 9:59 a.m. UTC 
The variables checked for are mandatory in all cases so a QA check does
not seem to be the right choice for this. Additionally, the code never
called `exit_if_errors` so the reported QA issue didn't actually fail
the task.

Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
---
 meta/classes-global/insane.bbclass  | 2 +-
 meta/classes-global/package.bbclass | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 4ef664b3cee..fed8163c3e0 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -35,7 +35,7 @@  CHECKLAYER_REQUIRED_TESTS = "\
     packages-list patch-fuzz patch-status perllocalpod perm-config perm-line perm-link recipe-naming \
     pkgconfig pkgvarcheck pkgv-undefined pn-overrides shebang-size src-uri-bad symlink-to-sysroot \
     unhandled-features-check unknown-configure-option unlisted-pkg-lics uppercase-pn useless-rpaths \
-    var-undefined virtual-slash xorg-driver-abi"
+    virtual-slash xorg-driver-abi"
 
 # Elect whether a given type of error is a warning or error, they may
 # have been set by other files.
diff --git a/meta/classes-global/package.bbclass b/meta/classes-global/package.bbclass
index 9be1d6a5b17..d7ff333f202 100644
--- a/meta/classes-global/package.bbclass
+++ b/meta/classes-global/package.bbclass
@@ -494,8 +494,7 @@  python do_package () {
     pn = d.getVar('PN')
 
     if not workdir or not outdir or not dest or not dvar or not pn:
-        msg = "WORKDIR, DEPLOY_DIR, D, PN and PKGD all must be defined, unable to package"
-        oe.qa.handle_error("var-undefined", msg, d)
+        bb.fatal("WORKDIR, DEPLOY_DIR, D, PN and PKGD all must be defined, unable to package")
         return
 
     bb.build.exec_func("package_setup_pkgv", d)