diff mbox series

[1/7] python_pep517: set CONFIGURE_FILES

Message ID 20250724161543.2253776-1-ross.burton@arm.com
State New
Headers show
Series [1/7] python_pep517: set CONFIGURE_FILES | expand

Commit Message

Ross Burton July 24, 2025, 4:15 p.m. UTC
Move the CONFIGURE_FILES assignment from python_mesonpy to the common
class, as it isn't specific to mesonpy.

Also extend, so that it doesn't clobber existing settings.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/classes-recipe/python_mesonpy.bbclass | 2 --
 meta/classes-recipe/python_pep517.bbclass  | 3 +++
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Mathieu Dubois-Briand July 25, 2025, 8:07 a.m. UTC | #1
On Thu Jul 24, 2025 at 6:15 PM CEST, Ross Burton via lists.openembedded.org wrote:
> Move the CONFIGURE_FILES assignment from python_mesonpy to the common
> class, as it isn't specific to mesonpy.
>
> Also extend, so that it doesn't clobber existing settings.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---

Hi Ross,

It looks like one of these patches is breaking several builds:

ERROR: Logfile of failure stored in: /srv/pokybuild/yocto-worker/build-appliance/build/build/tmp/work/core2-64-poky-linux/python3-smmap/6.0.0/temp/log.do_compile.2629166
Log data follows:
| DEBUG: Executing shell function do_compile
| /srv/pokybuild/yocto-worker/build-appliance/build/build/tmp/work/core2-64-poky-linux/python3-smmap/6.0.0/recipe-sysroot-native/usr/lib/python3.13/site-packages/setuptools/dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
| !!
|
|         ********************************************************************************
|         Please consider removing the following classifiers in favor of a SPDX license expression:
|
|         License :: OSI Approved :: BSD License
|
|         See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
|         ********************************************************************************
|
| !!
|   self._finalize_license_expression()
| usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
|    or: setup.py --help [cmd1 cmd2 ...]
|    or: setup.py --help-commands
|    or: setup.py cmd --help
|
| error: option -l not recognized
| WARNING: exit code 1 from a shell command.

Or a similar one with python3-magic-native.

https://autobuilder.yoctoproject.org/valkyrie/#/builders/78/builds/2136
https://autobuilder.yoctoproject.org/valkyrie/#/builders/37/builds/2168
https://autobuilder.yoctoproject.org/valkyrie/#/builders/50/builds/2127

Can you have a look at these please?
diff mbox series

Patch

diff --git a/meta/classes-recipe/python_mesonpy.bbclass b/meta/classes-recipe/python_mesonpy.bbclass
index 81c087c7c75..37b231cef53 100644
--- a/meta/classes-recipe/python_mesonpy.bbclass
+++ b/meta/classes-recipe/python_mesonpy.bbclass
@@ -17,8 +17,6 @@  meson_do_qa_configure () {
 # ERROR: Got argument buildtype as both -Dbuildtype and --buildtype. Pick one.
 MESONOPTS:remove = "--buildtype ${MESON_BUILDTYPE}"
 
-CONFIGURE_FILES = "pyproject.toml"
-
 DEPENDS += "python3-wheel-native python3-meson-python-native"
 
 def mesonpy_get_args(d):
diff --git a/meta/classes-recipe/python_pep517.bbclass b/meta/classes-recipe/python_pep517.bbclass
index e8cd1923ef2..2c144d39b38 100644
--- a/meta/classes-recipe/python_pep517.bbclass
+++ b/meta/classes-recipe/python_pep517.bbclass
@@ -61,3 +61,6 @@  python_pep517_do_bootstrap_install () {
 }
 
 EXPORT_FUNCTIONS do_configure do_compile do_install
+
+# Tell externalsrc this changing means it needs to reconfigure
+CONFIGURE_FILES += "pyproject.toml"