Message ID | 20250711155136.2172651-2-ross.burton@arm.com |
---|---|
State | New |
Headers | show |
Series | [1/3] clang: move BPN assignment from common.inc | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/2-3-llvm-tblgen-native-add-new-recipe.patch FAIL: test Signed-off-by presence: Mbox is missing Signed-off-by. Add it manually or with "git commit --amend -s" (test_mbox.TestMbox.test_signed_off_by_presence) PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files) PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) PASS: test lic files chksum presence (test_metadata.TestMetadata.test_lic_files_chksum_presence) PASS: test license presence (test_metadata.TestMetadata.test_license_presence) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files) PASS: test summary presence (test_metadata.TestMetadata.test_summary_presence) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
On 7/11/25 8:51 AM, Ross Burton via lists.openembedded.org wrote: > Building the LLVM projects often means using the TableGen tools > (llvm-tblgen etc). > > We currently build them as part of clang-native, but I am teasing the > clang recipe into its component parts and having to build llvm-native > or lldb-native simply for one tool isn't ideal. > > Instead, add a native recipe that simply builds the tablegen binaries > for llvm, clang, and lldb > --- > meta/conf/distro/include/maintainers.inc | 1 + > meta/recipes-devtools/clang/clang_git.bb | 10 +++---- > .../clang/llvm-tblgen-native_git.bb | 27 +++++++++++++++++++ > 3 files changed, 32 insertions(+), 6 deletions(-) > create mode 100644 meta/recipes-devtools/clang/llvm-tblgen-native_git.bb > > diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc > index 60f04da6089..331c438fd67 100644 > --- a/meta/conf/distro/include/maintainers.inc > +++ b/meta/conf/distro/include/maintainers.inc > @@ -480,6 +480,7 @@ RECIPE_MAINTAINER:pn-linux-yocto-dev = "Bruce Ashfield <bruce.ashfield@gmail.com > RECIPE_MAINTAINER:pn-linux-yocto-rt = "Bruce Ashfield <bruce.ashfield@gmail.com>" > RECIPE_MAINTAINER:pn-linux-yocto-tiny = "Bruce Ashfield <bruce.ashfield@gmail.com>" > RECIPE_MAINTAINER:pn-llvm-project-source-20.1.7 = "Khem Raj <raj.khem@gmail.com>" > +RECIPE_MAINTAINER:pn-llvm-tblgen-native = "Khem Raj <raj.khem@gmail.com>" > RECIPE_MAINTAINER:pn-logrotate = "Yi Zhao <yi.zhao@windriver.com>" > RECIPE_MAINTAINER:pn-log4cplus = "Unassigned <unassigned@yoctoproject.org>" > RECIPE_MAINTAINER:pn-lrzsz = "Anuj Mittal <anuj.mittal@intel.com>" > diff --git a/meta/recipes-devtools/clang/clang_git.bb b/meta/recipes-devtools/clang/clang_git.bb > index 2b5d3a27524..0f1b950cc63 100644 > --- a/meta/recipes-devtools/clang/clang_git.bb > +++ b/meta/recipes-devtools/clang/clang_git.bb > @@ -207,7 +207,7 @@ EXTRA_OECMAKE:append:class-target = "\ > -DLLDB_PYTHON_EXT_SUFFIX=${SOLIBSDEV} \ > " > > -DEPENDS = "binutils zlib zstd libffi libxml2 libxml2-native ninja-native swig-native spirv-tools-native" > +DEPENDS = "binutils zlib zstd libffi libxml2 libxml2-native ninja-native swig-native spirv-tools-native llvm-tblgen-native" > DEPENDS:append:class-nativesdk = " clang-crosssdk-${SDK_SYS} virtual/nativesdk-cross-binutils nativesdk-python3" > DEPENDS:append:class-target = " clang-cross-${TARGET_ARCH} python3 ${@bb.utils.contains('TC_CXX_RUNTIME', 'llvm', 'compiler-rt libcxx', '', d)} spirv-llvm-translator-native" > > @@ -276,18 +276,16 @@ do_install:append:class-native () { > install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clangd-indexer ${D}${bindir}/clangd-indexer > fi > install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clang-tidy-confusable-chars-gen ${D}${bindir}/clang-tidy-confusable-chars-gen > - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clang-tblgen ${D}${bindir}/clang-tblgen > - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/lldb-tblgen ${D}${bindir}/lldb-tblgen > - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/llvm-min-tblgen ${D}${bindir}/llvm-min-tblgen they are not installed but They are still being built internally I suppose ? in that case I wonder if it can use the binaries from llvm-tblgen-native during build and we can disable them from build in clang-native explicitly, should save some more time > install -Dm 0755 ${B}${BINPATHPREFIX}/bin/prepare_builtins ${D}${bindir}/prepare_builtins > > for f in `find ${D}${bindir} -executable -type f -not -type l`; do > test -n "`file -b $f|grep -i ELF`" && ${STRIP} $f > echo "stripped $f" > done > - ln -sf clang-tblgen ${D}${bindir}/clang-tblgen${PV} > - ln -sf llvm-tblgen ${D}${bindir}/llvm-tblgen${PV} > ln -sf llvm-config ${D}${bindir}/llvm-config${PV} > + > + # These are provided by llvm-tblgen-native > + rm ${D}${bindir}/*-tblgen > } > > do_install:append:class-nativesdk () { > diff --git a/meta/recipes-devtools/clang/llvm-tblgen-native_git.bb b/meta/recipes-devtools/clang/llvm-tblgen-native_git.bb > new file mode 100644 > index 00000000000..be04c1aa4d1 > --- /dev/null > +++ b/meta/recipes-devtools/clang/llvm-tblgen-native_git.bb > @@ -0,0 +1,27 @@ > +SUMMARY = "LLVM TableGen binaries, for the build host" > +SECTION = "devel" > + > +# Building the LLVM projects often means using the TableGen tools (llvm-tblgen, > +# etc). We could build these as part of llvm-native, but there are cases where > +# this would be overkill. For example, building a target LLDB needs native > +# tablegen binaries and a target libllvm so having to build a complete native > +# llvm is not needed. > + > +require common-clang.inc > +require common-source.inc > + > +inherit cmake pkgconfig native > + > +OECMAKE_SOURCEPATH = "${S}/llvm" > + > +EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='llvm;clang;lldb'" > + > +BINARIES = "llvm-min-tblgen llvm-tblgen clang-tblgen lldb-tblgen" > + > +OECMAKE_TARGET_COMPILE = "${BINARIES}" > + > +do_install() { > + for f in ${BINARIES}; do > + install -D ${B}/bin/$f ${D}${bindir}/$f > + done > +} > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#220146): https://lists.openembedded.org/g/openembedded-core/message/220146 > Mute This Topic: https://lists.openembedded.org/mt/114102602/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 11 Jul 2025, at 17:35, Khem Raj <raj.khem@gmail.com> wrote: >> install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clang-tidy-confusable-chars-gen ${D}${bindir}/clang-tidy-confusable-chars-gen >> - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clang-tblgen ${D}${bindir}/clang-tblgen >> - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/lldb-tblgen ${D}${bindir}/lldb-tblgen >> - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/llvm-min-tblgen ${D}${bindir}/llvm-min-tblgen > > they are not installed but They are still being built internally I suppose ? in that case I wonder if it can use the binaries from llvm-tblgen-native during build and we can disable them from build in clang-native explicitly, should save some more time Annoyingly, the native build does build its own copies even though I’ve told it where to find existing binaries. Probably some quirk or another argument needed, feel free to figure out what I’m missing ;) Ross
diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc index 60f04da6089..331c438fd67 100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -480,6 +480,7 @@ RECIPE_MAINTAINER:pn-linux-yocto-dev = "Bruce Ashfield <bruce.ashfield@gmail.com RECIPE_MAINTAINER:pn-linux-yocto-rt = "Bruce Ashfield <bruce.ashfield@gmail.com>" RECIPE_MAINTAINER:pn-linux-yocto-tiny = "Bruce Ashfield <bruce.ashfield@gmail.com>" RECIPE_MAINTAINER:pn-llvm-project-source-20.1.7 = "Khem Raj <raj.khem@gmail.com>" +RECIPE_MAINTAINER:pn-llvm-tblgen-native = "Khem Raj <raj.khem@gmail.com>" RECIPE_MAINTAINER:pn-logrotate = "Yi Zhao <yi.zhao@windriver.com>" RECIPE_MAINTAINER:pn-log4cplus = "Unassigned <unassigned@yoctoproject.org>" RECIPE_MAINTAINER:pn-lrzsz = "Anuj Mittal <anuj.mittal@intel.com>" diff --git a/meta/recipes-devtools/clang/clang_git.bb b/meta/recipes-devtools/clang/clang_git.bb index 2b5d3a27524..0f1b950cc63 100644 --- a/meta/recipes-devtools/clang/clang_git.bb +++ b/meta/recipes-devtools/clang/clang_git.bb @@ -207,7 +207,7 @@ EXTRA_OECMAKE:append:class-target = "\ -DLLDB_PYTHON_EXT_SUFFIX=${SOLIBSDEV} \ " -DEPENDS = "binutils zlib zstd libffi libxml2 libxml2-native ninja-native swig-native spirv-tools-native" +DEPENDS = "binutils zlib zstd libffi libxml2 libxml2-native ninja-native swig-native spirv-tools-native llvm-tblgen-native" DEPENDS:append:class-nativesdk = " clang-crosssdk-${SDK_SYS} virtual/nativesdk-cross-binutils nativesdk-python3" DEPENDS:append:class-target = " clang-cross-${TARGET_ARCH} python3 ${@bb.utils.contains('TC_CXX_RUNTIME', 'llvm', 'compiler-rt libcxx', '', d)} spirv-llvm-translator-native" @@ -276,18 +276,16 @@ do_install:append:class-native () { install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clangd-indexer ${D}${bindir}/clangd-indexer fi install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clang-tidy-confusable-chars-gen ${D}${bindir}/clang-tidy-confusable-chars-gen - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/clang-tblgen ${D}${bindir}/clang-tblgen - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/lldb-tblgen ${D}${bindir}/lldb-tblgen - install -Dm 0755 ${B}${BINPATHPREFIX}/bin/llvm-min-tblgen ${D}${bindir}/llvm-min-tblgen install -Dm 0755 ${B}${BINPATHPREFIX}/bin/prepare_builtins ${D}${bindir}/prepare_builtins for f in `find ${D}${bindir} -executable -type f -not -type l`; do test -n "`file -b $f|grep -i ELF`" && ${STRIP} $f echo "stripped $f" done - ln -sf clang-tblgen ${D}${bindir}/clang-tblgen${PV} - ln -sf llvm-tblgen ${D}${bindir}/llvm-tblgen${PV} ln -sf llvm-config ${D}${bindir}/llvm-config${PV} + + # These are provided by llvm-tblgen-native + rm ${D}${bindir}/*-tblgen } do_install:append:class-nativesdk () { diff --git a/meta/recipes-devtools/clang/llvm-tblgen-native_git.bb b/meta/recipes-devtools/clang/llvm-tblgen-native_git.bb new file mode 100644 index 00000000000..be04c1aa4d1 --- /dev/null +++ b/meta/recipes-devtools/clang/llvm-tblgen-native_git.bb @@ -0,0 +1,27 @@ +SUMMARY = "LLVM TableGen binaries, for the build host" +SECTION = "devel" + +# Building the LLVM projects often means using the TableGen tools (llvm-tblgen, +# etc). We could build these as part of llvm-native, but there are cases where +# this would be overkill. For example, building a target LLDB needs native +# tablegen binaries and a target libllvm so having to build a complete native +# llvm is not needed. + +require common-clang.inc +require common-source.inc + +inherit cmake pkgconfig native + +OECMAKE_SOURCEPATH = "${S}/llvm" + +EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='llvm;clang;lldb'" + +BINARIES = "llvm-min-tblgen llvm-tblgen clang-tblgen lldb-tblgen" + +OECMAKE_TARGET_COMPILE = "${BINARIES}" + +do_install() { + for f in ${BINARIES}; do + install -D ${B}/bin/$f ${D}${bindir}/$f + done +}