diff mbox series

[v3,1/1] systemd: add rdepends on libnss-resolve to nss-resolve PACKAGECONFIG

Message ID 20250708153030.3324742-2-pascal.weisser.ext@karlstorz.com
State Accepted, archived
Commit e3558ccc2e75bcd09d4a02799df9615cfa92fdbb
Headers show
Series systemd: add rdepends on libnss-resolve to nss-resolve PACKAGECONFIG | expand

Commit Message

Weisser, Pascal July 8, 2025, 3:30 p.m. UTC
Add a runtime dependency on libnss-resolve to nss-resolve PACKAGECONFIG in
systemd recipe. libnss-resolve provides nss-resolve which is a plug-in
module for the GNU Name Service Switch (NSS) functionality of the GNU C
Library (glibc) enabling it to resolve hostnames via the systemd-resolved
local network name resolution service.

See https://man7.org/linux/man-pages/man8/nss-resolve.8.html.

Runtime dependencies on other NSS plug-in modules are provided via other
PACKAGECONFIG entries in a similar way (myhostname - libnss-myhostname,
nss - libnss-resolve).

Signed-off-by: Weisser, Pascal <pascal.weisser.ext@karlstorz.com>
---
 meta/recipes-core/systemd/systemd_257.6.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

AdrianF July 10, 2025, 9:48 a.m. UTC | #1
On Tue, 2025-07-08 at 17:30 +0200, Weisser, Pascal.ext via
lists.openembedded.org wrote:
> Add a runtime dependency on libnss-resolve to nss-resolve
> PACKAGECONFIG in
> systemd recipe. libnss-resolve provides nss-resolve which is a plug-
> in
> module for the GNU Name Service Switch (NSS) functionality of the GNU
> C
> Library (glibc) enabling it to resolve hostnames via the systemd-
> resolved
> local network name resolution service.
> 
> See https://man7.org/linux/man-pages/man8/nss-resolve.8.html.
> 
> Runtime dependencies on other NSS plug-in modules are provided via
> other
> PACKAGECONFIG entries in a similar way (myhostname - libnss-
> myhostname,
> nss - libnss-resolve).
> 
> Signed-off-by: Weisser, Pascal <pascal.weisser.ext@karlstorz.com>

The comma causes some issues in the patch processing. Would it be
possible to remove it? (It's a bug in the patch processing tools)

> ---
>  meta/recipes-core/systemd/systemd_257.6.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_257.6.bb
> b/meta/recipes-core/systemd/systemd_257.6.bb
> index 5f7f20c434..9092d02c51 100644
> --- a/meta/recipes-core/systemd/systemd_257.6.bb
> +++ b/meta/recipes-core/systemd/systemd_257.6.bb
> @@ -189,7 +189,7 @@ PACKAGECONFIG[no-dns-fallback] = "-Ddns-servers="
>  PACKAGECONFIG[no-ntp-fallback] = "-Dntp-servers="
>  PACKAGECONFIG[nss] = "-Dnss-systemd=true,-Dnss-
> systemd=false,,libnss-systemd"
>  PACKAGECONFIG[nss-mymachines] = "-Dnss-mymachines=enabled,-Dnss-
> mymachines=disabled"
> -PACKAGECONFIG[nss-resolve] = "-Dnss-resolve=enabled,-Dnss-
> resolve=disabled"
> +PACKAGECONFIG[nss-resolve] = "-Dnss-resolve=enabled,-Dnss-
> resolve=disabled,,libnss-resolve"

Adding a run-time dependency for a library is usually not needed.
Probably this is needed because systemd loads this library via dlopen.
If that's the case, would it be possible to mention this on a comment
or the commit message?

Thank you for the patch,
Adrian

>  PACKAGECONFIG[oomd] = "-Doomd=true,-Doomd=false"
>  PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-
> Dopenssl=disabled,openssl"
>  PACKAGECONFIG[p11kit] = "-Dp11kit=enabled,-Dp11kit=disabled,p11-kit"
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#220049):
> https://lists.openembedded.org/g/openembedded-core/message/220049
> Mute This Topic: https://lists.openembedded.org/mt/114048455/3616858
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> adrian.freihofer@siemens.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
AdrianF July 12, 2025, 12:20 p.m. UTC | #2
Hi Pascal

After our private discussion, I realized my question actually pertained
to v2, but I mistakenly addressed it in the context of v3. For clarity,
v3 looks good.

Thank you,
Adrian

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#220115):
> https://lists.openembedded.org/g/openembedded-core/message/220115
> Mute This Topic: https://lists.openembedded.org/mt/114048455/3616858
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> adrian.freihofer@siemens.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-core/systemd/systemd_257.6.bb b/meta/recipes-core/systemd/systemd_257.6.bb
index 5f7f20c434..9092d02c51 100644
--- a/meta/recipes-core/systemd/systemd_257.6.bb
+++ b/meta/recipes-core/systemd/systemd_257.6.bb
@@ -189,7 +189,7 @@  PACKAGECONFIG[no-dns-fallback] = "-Ddns-servers="
 PACKAGECONFIG[no-ntp-fallback] = "-Dntp-servers="
 PACKAGECONFIG[nss] = "-Dnss-systemd=true,-Dnss-systemd=false,,libnss-systemd"
 PACKAGECONFIG[nss-mymachines] = "-Dnss-mymachines=enabled,-Dnss-mymachines=disabled"
-PACKAGECONFIG[nss-resolve] = "-Dnss-resolve=enabled,-Dnss-resolve=disabled"
+PACKAGECONFIG[nss-resolve] = "-Dnss-resolve=enabled,-Dnss-resolve=disabled,,libnss-resolve"
 PACKAGECONFIG[oomd] = "-Doomd=true,-Doomd=false"
 PACKAGECONFIG[openssl] = "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
 PACKAGECONFIG[p11kit] = "-Dp11kit=enabled,-Dp11kit=disabled,p11-kit"