| Message ID | 20250627061346.9351-1-Moritz.Haase@bmw.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] json-c: Remove icecc specific comment | expand |
diff --git a/meta/recipes-devtools/json-c/json-c_0.18.bb b/meta/recipes-devtools/json-c/json-c_0.18.bb index ece320d66ce1f03ce0c8655374c02c283a9364dd..c112aacf4bceb0c41dbe2e1643d2d7e0944bf250 100644 --- a/meta/recipes-devtools/json-c/json-c_0.18.bb +++ b/meta/recipes-devtools/json-c/json-c_0.18.bb @@ -19,8 +19,7 @@ UPSTREAM_CHECK_REGEX = "json-c-(?P<pver>\d+(\.\d+)+)-\d+" RPROVIDES:${PN} = "libjson" -# - '-Werror' must be disabled for ICECC builds -# - Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+. +# Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+. EXTRA_OECMAKE = "-DDISABLE_WERROR=ON \ -DBUILD_APPS=OFF \ "
6481e8b209b ("json-c: fix icecc compilation") disabled '-Werror' unconditionally for all compilers. We want to keep it disabled to reduce efforts when updating or adding support for new toolchains (see [0]), but since support for icecc has been removed via ba4fd5229893 ("classes/recipes-devtools: Drop icecc from OE-Core") recently, we can drop the comment referencing it. [0]: https://lists.openembedded.org/g/openembedded-core/message/219364 Signed-off-by: Moritz Haase <Moritz.Haase@bmw.de> CC: quentin.schulz@cherry.de CC: m.felsch@pengutronix.de CC: ross.burton@arm.com --- changes in v2: - Re-enabled '-Werror' as suggested in [0], updated commit title/message accordingly. --- meta/recipes-devtools/json-c/json-c_0.18.bb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)