diff mbox series

[1/5] python3-colorama: add recipe

Message ID 20250617155339.1305652-1-tgamblin@baylibre.com
State Accepted, archived
Commit 8c06239fdcf983dac759c7d80d6326807c993622
Headers show
Series [1/5] python3-colorama: add recipe | expand

Commit Message

Trevor Gamblin June 17, 2025, 3:53 p.m. UTC
Add existing recipe from meta-python, since pytest lists it as a
dependency. This also puts it in maintainers.inc with myself as
maintainer.

Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
---
 meta/conf/distro/include/maintainers.inc           |  1 +
 .../python/python3-colorama_0.4.6.bb               | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-colorama_0.4.6.bb

Comments

Ross Burton June 19, 2025, 1:31 p.m. UTC | #1
On 17 Jun 2025, at 16:53, Trevor Gamblin via lists.openembedded.org <tgamblin=baylibre.com@lists.openembedded.org> wrote:
> +inherit pypi python_setuptools_build_meta

So this package uses a modern setuptools to build.

> +DEPENDS += " \
> + python3-hatchling-native \
> +"

So this package uses hatchling to build.

One of these is wrong :)

I suspect the recipe should inherit python_hatchling and not have a DEPENDS?

Ross
Trevor Gamblin June 19, 2025, 1:49 p.m. UTC | #2
On 2025-06-19 09:31, Ross Burton wrote:
> On 17 Jun 2025, at 16:53, Trevor Gamblin via lists.openembedded.org <tgamblin=baylibre.com@lists.openembedded.org> wrote:
>> +inherit pypi python_setuptools_build_meta
> So this package uses a modern setuptools to build.
>
>> +DEPENDS += " \
>> + python3-hatchling-native \
>> +"
> So this package uses hatchling to build.
>
> One of these is wrong :)
>
> I suspect the recipe should inherit python_hatchling and not have a DEPENDS?
You may be right. Trying out a build with the change now. If it works 
I'll re-send.
>
> Ross
>
Richard Purdie June 19, 2025, 1:54 p.m. UTC | #3
On Thu, 2025-06-19 at 09:49 -0400, Trevor Gamblin via
lists.openembedded.org wrote:
> 
> On 2025-06-19 09:31, Ross Burton wrote:
> > On 17 Jun 2025, at 16:53, Trevor Gamblin via lists.openembedded.org
> > <tgamblin=baylibre.com@lists.openembedded.org> wrote:
> > > +inherit pypi python_setuptools_build_meta
> > So this package uses a modern setuptools to build.
> > 
> > > +DEPENDS += " \
> > > + python3-hatchling-native \
> > > +"
> > So this package uses hatchling to build.
> > 
> > One of these is wrong :)
> > 
> > I suspect the recipe should inherit python_hatchling and not have a
> > DEPENDS?
> You may be right. Trying out a build with the change now. If it works
> I'll re-send.
> 

I did tweak the version in master-next since I needed to retest other
things as well. I think it has tested ok...

Cheers,

Richard
Trevor Gamblin June 19, 2025, 1:56 p.m. UTC | #4
On 2025-06-19 09:54, Richard Purdie wrote:
> On Thu, 2025-06-19 at 09:49 -0400, Trevor Gamblin via
> lists.openembedded.org wrote:
>> On 2025-06-19 09:31, Ross Burton wrote:
>>> On 17 Jun 2025, at 16:53, Trevor Gamblin via lists.openembedded.org
>>> <tgamblin=baylibre.com@lists.openembedded.org> wrote:
>>>> +inherit pypi python_setuptools_build_meta
>>> So this package uses a modern setuptools to build.
>>>
>>>> +DEPENDS += " \
>>>> + python3-hatchling-native \
>>>> +"
>>> So this package uses hatchling to build.
>>>
>>> One of these is wrong :)
>>>
>>> I suspect the recipe should inherit python_hatchling and not have a
>>> DEPENDS?
>> You may be right. Trying out a build with the change now. If it works
>> I'll re-send.
>>
> I did tweak the version in master-next since I needed to retest other
> things as well. I think it has tested ok...
I see that now. LGTM.
>
> Cheers,
>
> Richard
diff mbox series

Patch

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index b6cf4b7cfa..5d2ac05b27 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -623,6 +623,7 @@  RECIPE_MAINTAINER:pn-python3-beartype = "Marta Rybczynska <marta.rybczynska@ygre
 RECIPE_MAINTAINER:pn-python3-booleanpy = "zhengrq.fnst <zhengrq.fnst@fujitsu.com>"
 RECIPE_MAINTAINER:pn-python3-build = "Ross Burton <ross.burton@arm.com>"
 RECIPE_MAINTAINER:pn-python3-calver = "Trevor Gamblin <tgamblin@baylibre.com>"
+RECIPE_MAINTAINER:pn-python3-colorama = "Trevor Gamblin <tgamblin@baylibre.com>"
 RECIPE_MAINTAINER:pn-python3-certifi = "Tim Orling <tim.orling@konsulko.com>"
 RECIPE_MAINTAINER:pn-python3-cffi = "Tim Orling <tim.orling@konsulko.com>"
 RECIPE_MAINTAINER:pn-python3-chardet = "Tim Orling <tim.orling@konsulko.com>"
diff --git a/meta/recipes-devtools/python/python3-colorama_0.4.6.bb b/meta/recipes-devtools/python/python3-colorama_0.4.6.bb
new file mode 100644
index 0000000000..3871244031
--- /dev/null
+++ b/meta/recipes-devtools/python/python3-colorama_0.4.6.bb
@@ -0,0 +1,14 @@ 
+SUMMARY = "Cross-platform colored terminal text."
+HOMEPAGE = "https://github.com/tartley/colorama"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=b4936429a56a652b84c5c01280dcaa26"
+
+inherit pypi python_setuptools_build_meta
+
+SRC_URI[sha256sum] = "08695f5cb7ed6e0531a20572697297273c47b8cae5a63ffc6d6ed5c201be6e44"
+
+DEPENDS += " \
+	python3-hatchling-native \
+"
+
+BBCLASSEXTEND = "native nativesdk"