| Message ID | 20250617052540.8256-3-victor.kamensky7@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] systemtap: upgrade 5.2 -> 5.3 | expand |
diff --git a/meta/lib/oeqa/runtime/cases/stap.py b/meta/lib/oeqa/runtime/cases/stap.py index 23eace7e9d..6b55e7de50 100644 --- a/meta/lib/oeqa/runtime/cases/stap.py +++ b/meta/lib/oeqa/runtime/cases/stap.py @@ -26,6 +26,7 @@ class StapTest(OERuntimeTestCase): self.assertEqual(status, 0, msg='\n'.join([cmd, output])) cmd = 'staprun -v -R -b1 stap_hello.ko' + status, output = self.target.run(cmd, 60) self.assertEqual(status, 0, msg='\n'.join([cmd, output])) self.assertIn('Hello, SystemTap!', output, msg='\n'.join([cmd, output])) except:
Looks as a typo introduced by "6cf4d23a2d26c2767edd93f2eb317ff759b5a992 (oeqa/runtime/stap: improve systemtap test)" - when original command was split into two parts 'self.target.run' was missed for the second part. Note this and previos commit issues were masked because mentioned commit has try/except around tests, so failures that normally are reported when test assertEqual throw an exception never reached oeqa infra. Effectively, this test was broken for the last 3 years. I will leave blanket try/except around test for now, so this test will pass all the time as long as dmesg is working. But at least with the fixes one can inspect log.do_testimage output and check that all steps are successful or not. Signed-off-by: Victor Kamensky <victor.kamensky7@gmail.com> --- meta/lib/oeqa/runtime/cases/stap.py | 1 + 1 file changed, 1 insertion(+)