| Message ID | 20250610094400.1653931-2-alex.kanavin@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,1/9] bitbake.conf: set BB_GIT_DEFAULT_DESTSUFFIX to match default S value | expand |
On Tue, 2025-06-10 at 11:43 +0200, Alexander Kanavin via lists.openembedded.org wrote: > From: Alexander Kanavin <alex@linutronix.de> > > This is shorter and doesn't include the unnecessary task name, just the > result of it: source trees and files. > > Signed-off-by: Alexander Kanavin <alex@linutronix.de> > --- > meta/conf/bitbake.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 4fa72b3d3ac..780de10ba35 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -407,7 +407,7 @@ STAMP = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${PV}" > STAMPCLEAN = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/*-*" > BASE_WORKDIR ?= "${TMPDIR}/work" > WORKDIR = "${BASE_WORKDIR}/${MULTIMACH_TARGET_SYS}/${PN}/${PV}" > -UNPACKDIR ??= "${WORKDIR}/sources-unpack" > +UNPACKDIR ??= "${WORKDIR}/sources" > BB_GIT_DEFAULT_DESTSUFFIX = "${BP}" > T = "${WORKDIR}/temp" > D = "${WORKDIR}/image" FWIW this was previously rejected due to confusion with the default for DL_DIR often being "sources". Cheers, Richard
On Tue, 10 Jun 2025 at 14:24, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > FWIW this was previously rejected due to confusion with the default for > DL_DIR often being "sources". I'd like to look at that discussion, particularly to see what evidence was presented for 'often'. I'd still argue DL_DIR should have 'downloads' in it somewhere, as suggested in oe-core default (and variable name). There's already a number of recipes that set S to WORKDIR/sources and UNPACKDIR to S (and that pattern made it into the docs too), so from that perspective standardizing on 'sources' across oe-core is going to be less confusion. Alex
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 4fa72b3d3ac..780de10ba35 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -407,7 +407,7 @@ STAMP = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${PV}" STAMPCLEAN = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/*-*" BASE_WORKDIR ?= "${TMPDIR}/work" WORKDIR = "${BASE_WORKDIR}/${MULTIMACH_TARGET_SYS}/${PN}/${PV}" -UNPACKDIR ??= "${WORKDIR}/sources-unpack" +UNPACKDIR ??= "${WORKDIR}/sources" BB_GIT_DEFAULT_DESTSUFFIX = "${BP}" T = "${WORKDIR}/temp" D = "${WORKDIR}/image"