| Message ID | 20250605091828.50442-1-andrej.v@skyrain.eu |
|---|---|
| State | New |
| Headers | show |
| Series | [oe,meta] dropbear: add xauth runtime dependency when x11-forwarding is enabled | expand |
On 5 Jun 2025, at 10:18, Andrej Valek via lists.openembedded.org <andrej.v=skyrain.eu@lists.openembedded.org> wrote: > -PACKAGECONFIG[enable-x11-forwarding] = "" > +PACKAGECONFIG[enable-x11-forwarding] = “,,,xauth” It feels like this should be a recommends not a depends (so add another comma). Whilst you’re here: do you think we should enable x11 forwarding if x11 is in DISTRO_FEATURES by default, or is there a good reason to keep it disabled by default? Thanks, Ross
Hi Ross, What do you mean by "should be a recommends not a depends"? AFAIK: PACKAGECONFIG[x] = "with,without,depends,rdepends", so I would say my variant is ok, or? No, I'm fully on your side to enable the forwarding by default when x11 is enabled. Will you take a care of it, or should I? BR, Andy On 09.06.2025 18:54, Ross Burton via lists.openembedded.org wrote: > On 5 Jun 2025, at 10:18, Andrej Valek via lists.openembedded.org <andrej.v=skyrain.eu@lists.openembedded.org> wrote: >> -PACKAGECONFIG[enable-x11-forwarding] = "" >> +PACKAGECONFIG[enable-x11-forwarding] = “,,,xauth” > It feels like this should be a recommends not a depends (so add another comma). > > Whilst you’re here: do you think we should enable x11 forwarding if x11 is in DISTRO_FEATURES by default, or is there a good reason to keep it disabled by default? > > Thanks, > Ross > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#218301): https://lists.openembedded.org/g/openembedded-core/message/218301 > Mute This Topic: https://lists.openembedded.org/mt/113482164/3619876 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [andrej.v@skyrain.eu] > -=-=-=-=-=-=-=-=-=-=-=- >
On 10 Jun 2025, at 07:42, Andrej Valek <andrej.v@skyrain.eu> wrote: > > Hi Ross, > > What do you mean by "should be a recommends not a depends"? AFAIK: PACKAGECONFIG[x] = "with,without,depends,rdepends", so I would say my variant is ok, or? https://docs.yoctoproject.org/ref-manual/variables.html#term-PACKAGECONFIG The full syntax is with,without,depends,rdepends,rrecommends,conflicts so just adding an extra comma would make it a RRECOMMENDS not a RDEPENDS. My reasoning is that xauth isn’t _needed_ for ssh to work, so it could be useful to be able to build it with X support but not actually install xauth in otherwise headless images. > No, I'm fully on your side to enable the forwarding by default when x11 is enabled. > > Will you take a care of it, or should I? If you can send a second patch, that would be great. Ross
diff --git a/meta/recipes-core/dropbear/dropbear_2025.88.bb b/meta/recipes-core/dropbear/dropbear_2025.88.bb index f203763b17..a1317d3b73 100644 --- a/meta/recipes-core/dropbear/dropbear_2025.88.bb +++ b/meta/recipes-core/dropbear/dropbear_2025.88.bb @@ -51,7 +51,7 @@ EXTRA_OEMAKE = 'MULTI=1 SCPPROGRESS=1 PROGRAMS="${SBINCOMMANDS} ${BINCOMMANDS}"' PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}" PACKAGECONFIG[pam] = "--enable-pam,--disable-pam,libpam,${PAM_PLUGINS}" PACKAGECONFIG[system-libtom] = "--disable-bundled-libtom,--enable-bundled-libtom,libtommath libtomcrypt" -PACKAGECONFIG[enable-x11-forwarding] = "" +PACKAGECONFIG[enable-x11-forwarding] = ",,,xauth" # This option appends to CFLAGS and LDFLAGS from OE # This is causing [textrel] QA warning
Even if enable-x11-forwarding was used, XAUTH_COMMAND failed due to missing xauth. Signed-off-by: Andrej Valek <andrej.v@skyrain.eu> --- meta/recipes-core/dropbear/dropbear_2025.88.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)