diff mbox series

[v2] perf: add arm64 source files for unistd_64.h

Message ID 20250605-perf-arm64-unistd-v2-1-c86ff172b167@phytec.de
State New
Headers show
Series [v2] perf: add arm64 source files for unistd_64.h | expand

Commit Message

Yannic Moog June 5, 2025, 7:23 a.m. UTC
kernel commit bfb713ea53c7 ("perf tools: Fix arm64 build by generating unistd_64.h")
introduces a new dependency on source files for arm64, specifically
include/uapi/asm-generic.

Build fails with:
[..]/perf/1.0/perf-1.0/scripts/Makefile.asm-headers:33: [...]/perf/1.0/perf-1.0/include/uapi/asm-generic/Kbuild: No such file or directory
make[4]: *** No rule to make target '[...]/perf/1.0/perf-1.0/include/uapi/asm-generic/Kbuild'.  Stop.

Add the directory to PERF_SRC.
Fix whitespace error while at it.

Signed-off-by: Yannic Moog <y.moog@phytec.de>
---
Changes in v2:
- only include KBuild instead of whole directory
- remove ARCH=arm64 condition for inclusion
- Link to v1: https://patchwork.yoctoproject.org/project/oe-core/patch/20250604-perf-arm64-unistd-v1-1-97d3bb08927f@phytec.de/
---
 meta/recipes-kernel/perf/perf.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


---
base-commit: ae97991a5c634d2ac0ea3bed29bb7aaa9d9b793f
change-id: 20250603-perf-arm64-unistd-9344a6fc96a7

Best regards,

Comments

Bruce Ashfield June 5, 2025, 1:19 p.m. UTC | #1
On Thu, Jun 5, 2025 at 3:24 AM Yannic Moog via lists.openembedded.org
<y.moog=phytec.de@lists.openembedded.org> wrote:

> kernel commit bfb713ea53c7 ("perf tools: Fix arm64 build by generating
> unistd_64.h")
> introduces a new dependency on source files for arm64, specifically
> include/uapi/asm-generic.
>
> Build fails with:
> [..]/perf/1.0/perf-1.0/scripts/Makefile.asm-headers:33:
> [...]/perf/1.0/perf-1.0/include/uapi/asm-generic/Kbuild: No such file or
> directory
> make[4]: *** No rule to make target
> '[...]/perf/1.0/perf-1.0/include/uapi/asm-generic/Kbuild'.  Stop.
>
> Add the directory to PERF_SRC.
> Fix whitespace error while at it.
>
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> ---
> Changes in v2:
> - only include KBuild instead of whole directory
> - remove ARCH=arm64 condition for inclusion
> - Link to v1:
> https://patchwork.yoctoproject.org/project/oe-core/patch/20250604-perf-arm64-unistd-v1-1-97d3bb08927f@phytec.de/


Thanks for v2!

This looks good to me.

Bruce



>
> ---
>  meta/recipes-kernel/perf/perf.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/
> perf.bb
> index
> 0d19e1bdc222da26a5ad0a1d4964acca437a6692..6cc5499d8dd8b568a135ad767bd2dd53fc4dce13
> 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -151,6 +151,7 @@ PERF_SRC ?= "Makefile \
>               arch/arm64/tools \
>               ${PERF_BPF_EVENT_SRC} \
>               arch/${ARCH}/Makefile \
> +             include/uapi/asm-generic/Kbuild \
>  "
>
>  PERF_EXTRA_LDFLAGS = ""
> @@ -208,7 +209,7 @@ python copy_perf_source_from_kernel() {
>  do_configure:prepend () {
>      # If building a multlib based perf, the incorrect library path will be
>      # detected by perf, since it triggers via: ifeq ($(ARCH),x86_64). In
> a 32 bit
> -    # build, with a 64 bit multilib, the arch won't match and the
> detection of a
> +    # build, with a 64 bit multilib, the arch won't match and the
> detection of a
>      # 64 bit build (and library) are not exected. To ensure that
> libraries are
>      # installed to the correct location, we can use the weak assignment
> in the
>      # config/Makefile.
>
> ---
> base-commit: ae97991a5c634d2ac0ea3bed29bb7aaa9d9b793f
> change-id: 20250603-perf-arm64-unistd-9344a6fc96a7
>
> Best regards,
> --
> Yannic Moog <y.moog@phytec.de>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#217991):
> https://lists.openembedded.org/g/openembedded-core/message/217991
> Mute This Topic: https://lists.openembedded.org/mt/113481539/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 0d19e1bdc222da26a5ad0a1d4964acca437a6692..6cc5499d8dd8b568a135ad767bd2dd53fc4dce13 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -151,6 +151,7 @@  PERF_SRC ?= "Makefile \
              arch/arm64/tools \
              ${PERF_BPF_EVENT_SRC} \
              arch/${ARCH}/Makefile \
+             include/uapi/asm-generic/Kbuild \
 "
 
 PERF_EXTRA_LDFLAGS = ""
@@ -208,7 +209,7 @@  python copy_perf_source_from_kernel() {
 do_configure:prepend () {
     # If building a multlib based perf, the incorrect library path will be
     # detected by perf, since it triggers via: ifeq ($(ARCH),x86_64). In a 32 bit
-    # build, with a 64 bit multilib, the arch won't match and the detection of a 
+    # build, with a 64 bit multilib, the arch won't match and the detection of a
     # 64 bit build (and library) are not exected. To ensure that libraries are
     # installed to the correct location, we can use the weak assignment in the
     # config/Makefile.