diff mbox series

[1/5] perl-ptest: include gcc as a recommended package

Message ID 20250515165010.242349-2-rajendra.desai@emerson.com
State New
Headers show
Series perl-ptest: fix 5 of the ExtUtils ptests | expand

Commit Message

Rajendra Desai May 15, 2025, 4:50 p.m. UTC
The following perl ptests:

dist/ExtUtils-ParseXS/t/001-basic
dist/ExtUtils-ParseXS/t/002-more
dist/ExtUtils-ParseXS/t/003-usage

are giving out below warning while running on the yocto CI build:
Can't exec "x86_64-poky-linux-gcc": No such file or directory at
/usr/lib/perl/ptest/dist/ExtUtils-ParseXS/../../lib/ExtUtils/CBuilder/Base.pm
line 362.

additionally, 2 of the tests are skipping out:
SKIP: cpan/ExtUtils-Constant/t/Constant
SKIP: cpan/ExtUtils-MakeMaker/t/02-xsdynamic

This is mainly due to a missing gcc dependency which is needed by
the above tests. Hence, adding the package under RRECOMMENDS to
make sure the tests are able to find the compiler and that the
tests do not skip or output the missing file or directory warning.

Signed-off-by: Rajendra Desai <rajendra.desai@emerson.com>
---
 meta/recipes-devtools/perl/perl-ptest.inc | 1 +
 1 file changed, 1 insertion(+)

Comments

Richard Purdie May 16, 2025, 6:16 a.m. UTC | #1
On Thu, 2025-05-15 at 22:20 +0530, Rajendra Desai via lists.openembedded.org wrote:
> The following perl ptests:
> 
> dist/ExtUtils-ParseXS/t/001-basic
> dist/ExtUtils-ParseXS/t/002-more
> dist/ExtUtils-ParseXS/t/003-usage
> 
> are giving out below warning while running on the yocto CI build:
> Can't exec "x86_64-poky-linux-gcc": No such file or directory at
> /usr/lib/perl/ptest/dist/ExtUtils-ParseXS/../../lib/ExtUtils/CBuilder/Base.pm
> line 362.
> 
> additionally, 2 of the tests are skipping out:
> SKIP: cpan/ExtUtils-Constant/t/Constant
> SKIP: cpan/ExtUtils-MakeMaker/t/02-xsdynamic
> 
> This is mainly due to a missing gcc dependency which is needed by
> the above tests. Hence, adding the package under RRECOMMENDS to
> make sure the tests are able to find the compiler and that the
> tests do not skip or output the missing file or directory warning.
> 
> Signed-off-by: Rajendra Desai <rajendra.desai@emerson.com>
> ---
>  meta/recipes-devtools/perl/perl-ptest.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/perl/perl-ptest.inc b/meta/recipes-devtools/perl/perl-ptest.inc
> index 4b4756118c..817ad401f4 100644
> --- a/meta/recipes-devtools/perl/perl-ptest.inc
> +++ b/meta/recipes-devtools/perl/perl-ptest.inc
> @@ -60,6 +60,7 @@ python populate_packages:prepend() {
>  }
>  
>  RDEPENDS:${PN}-ptest += "${PN}-modules ${PN}-doc sed procps-ps"
> +RRECOMMENDS:${PN}-ptest += "gcc"
>  
>  # The perl-ptest package contains Perl internal modules and generating file
>  # dependencies for it causes problems.

We've avoided doing this as there are key elements of a build that
require perl and this means those builds will now build gcc. It
effectively means that even small images will end up building target
toolchain tools. I'm not sure that is what people want, even if it does
come at the price of a small number of skipped ptests.

We should perhaps comment this in the recipe through so people know
we've considered it.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/recipes-devtools/perl/perl-ptest.inc b/meta/recipes-devtools/perl/perl-ptest.inc
index 4b4756118c..817ad401f4 100644
--- a/meta/recipes-devtools/perl/perl-ptest.inc
+++ b/meta/recipes-devtools/perl/perl-ptest.inc
@@ -60,6 +60,7 @@  python populate_packages:prepend() {
 }
 
 RDEPENDS:${PN}-ptest += "${PN}-modules ${PN}-doc sed procps-ps"
+RRECOMMENDS:${PN}-ptest += "gcc"
 
 # The perl-ptest package contains Perl internal modules and generating file
 # dependencies for it causes problems.