| Message ID | 20250428154902.3084542-1-dmitry.baryshkov@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | libxt: fix build error | expand |
On Mon, 28 Apr 2025 at 17:49, Dmitry Baryshkov via lists.openembedded.org <dmitry.baryshkov=oss.qualcomm.com@lists.openembedded.org> wrote: > Building of libXt fails with: > > ../../libXt-1.3.1/src/ResConfig.c: In function '_get_part': > ../../libXt-1.3.1/src/ResConfig.c:421:23: error: the comparison will always evaluate as 'true' for the address of 'buffer' will never be NULL [-Werror=address] > ../../libXt-1.3.1/src/ResConfig.c:404:10: note: 'buffer' declared here > -EXTRA_OECONF += "--disable-xkb" > +EXTRA_OECONF += "--disable-xkb --disable-selective-werror" Same questions as with the graphene patch: why isn't it failing in the autobuilder and standard poky? Has upstream been notified? How can we know when we can remove this flag? Alex
> On 28 Apr 2025, at 19:30, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote: > > On Mon, 28 Apr 2025 at 17:49, Dmitry Baryshkov via > lists.openembedded.org > <dmitry.baryshkov=oss.qualcomm.com@lists.openembedded.org> wrote: >> Building of libXt fails with: >> >> ../../libXt-1.3.1/src/ResConfig.c: In function '_get_part': >> ../../libXt-1.3.1/src/ResConfig.c:421:23: error: the comparison will always evaluate as 'true' for the address of 'buffer' will never be NULL [-Werror=address] >> ../../libXt-1.3.1/src/ResConfig.c:404:10: note: 'buffer' declared here >> -EXTRA_OECONF += "--disable-xkb" >> +EXTRA_OECONF += "--disable-xkb --disable-selective-werror" > > Same questions as with the graphene patch: why isn't it failing in the > autobuilder and standard poky? Has upstream been notified? How can we > know when we can remove this flag? I’m _guessing_ GCC 15, but yes we don’t want to end up carrying patches or flags without making it clear when they can be removed. Ross
diff --git a/meta/recipes-graphics/xorg-lib/libxt_1.3.1.bb b/meta/recipes-graphics/xorg-lib/libxt_1.3.1.bb index 97323ad282ce..28915d1a2a20 100644 --- a/meta/recipes-graphics/xorg-lib/libxt_1.3.1.bb +++ b/meta/recipes-graphics/xorg-lib/libxt_1.3.1.bb @@ -29,4 +29,4 @@ SRC_URI[sha256sum] = "e0a774b33324f4d4c05b199ea45050f87206586d81655f8bef4dba434d BBCLASSEXTEND = "native nativesdk" -EXTRA_OECONF += "--disable-xkb" +EXTRA_OECONF += "--disable-xkb --disable-selective-werror"
Building of libXt fails with: ../../libXt-1.3.1/src/ResConfig.c: In function '_get_part': ../../libXt-1.3.1/src/ResConfig.c:421:23: error: the comparison will always evaluate as 'true' for the address of 'buffer' will never be NULL [-Werror=address] ../../libXt-1.3.1/src/ResConfig.c:404:10: note: 'buffer' declared here Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- meta/recipes-graphics/xorg-lib/libxt_1.3.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)