diff mbox series

graphene: disable one of error flags

Message ID 20250428154853.3084518-1-dmitry.baryshkov@oss.qualcomm.com
State New
Headers show
Series graphene: disable one of error flags | expand

Commit Message

Dmitry Baryshkov April 28, 2025, 3:48 p.m. UTC 
Building of graphene fails with the following error. Disable
corresponding flag being set by meson until the issue gets resolved
upstream.

../graphene-1.10.8/src/graphene-gobject.c: In function 'graphene_point_get_type':
../graphene-1.10.8/src/graphene-gobject.c:155:14: error: redundant redeclaration of '__Static_assert_function' [-Werror=redundant-decls]
../graphene-1.10.8/src/graphene-gobject.c:155:14: note: previous declaration of '__Static_assert_function' with type 'int (*(void))[1]'
../graphene-1.10.8/src/graphene-gobject.c:155:14: error: redundant redeclaration of '__Static_assert_function' [-Werror=redundant-decls]
../graphene-1.10.8/src/graphene-gobject.c:155:14: note: previous declaration of '__Static_assert_function' with type 'int (*(void))[1]'
../graphene-1.10.8/src/graphene-gobject.c: In function 'graphene_point3d_get_type':
../graphene-1.10.8/src/graphene-gobject.c:157:14: error: redundant redeclaration of '__Static_assert_function' [-Werror=redundant-decls]
../graphene-1.10.8/src/graphene-gobject.c:155:14: note: previous declaration of '__Static_assert_function' with type 'int (*(void))[1]'
../graphene-1.10.8/src/graphene-gobject.c:157:14: error: redundant redeclaration of '__Static_assert_function' [-Werror=redundant-decls]
../graphene-1.10.8/src/graphene-gobject.c:157:14: note: previous declaration of '__Static_assert_function' with type 'int (*(void))[1]'
../graphene-1.10.8/src/graphene-gobject.c:157:14: error: redundant redeclaration of '__Static_assert_function' [-Werror=redundant-decls]
../graphene-1.10.8/src/graphene-gobject.c:157:14: note: previous declaration of '__Static_assert_function' with type 'int (*(void))[1]'

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 ...build-disable-Werror-redundant-decls.patch | 32 +++++++++++++++++++
 .../graphene/graphene_1.10.8.bb               |  4 ++-
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-graphics/graphene/files/0001-meson.build-disable-Werror-redundant-decls.patch

Comments

Alexander Kanavin April 28, 2025, 6:25 p.m. UTC | #1 
On Mon, 28 Apr 2025 at 17:48, Dmitry Baryshkov via
lists.openembedded.org
<dmitry.baryshkov=oss.qualcomm.com@lists.openembedded.org> wrote:
>
> Building of graphene fails with the following error. Disable
> corresponding flag being set by meson until the issue gets resolved
> upstream.
> +Subject: [PATCH] meson.build: disable -Werror=redundant-decls
> +
> +Building of Graphene started to fail with the following errors. Disable
> +offending flag.
> +Upstream-Status: Pending

Not so quick please. This recipe does not fail on the autobuilder
(yocto ci), or in my local build (using standard poky), so there's
something else going on. You need to narrow down what really causes
the failure (something non-standard in your settings or toolchain?),
there should be a link to the upstream ticket, and the patch should
not be marked as Pending (unless a very good reason for that is
given).

Alex
diff mbox series

Patch

diff --git a/meta/recipes-graphics/graphene/files/0001-meson.build-disable-Werror-redundant-decls.patch b/meta/recipes-graphics/graphene/files/0001-meson.build-disable-Werror-redundant-decls.patch
new file mode 100644
index 000000000000..0aacd72257f5
--- /dev/null
+++ b/meta/recipes-graphics/graphene/files/0001-meson.build-disable-Werror-redundant-decls.patch
@@ -0,0 +1,32 @@ 
+From b8139367858b3473777c2819abdbc900e70648bb Mon Sep 17 00:00:00 2001
+From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
+Date: Mon, 28 Apr 2025 18:29:29 +0300
+Subject: [PATCH] meson.build: disable -Werror=redundant-decls
+
+Building of Graphene started to fail with the following errors. Disable
+offending flag.
+
+../graphene-1.10.8/src/graphene-gobject.c: In function 'graphene_point_get_type':
+../graphene-1.10.8/src/graphene-gobject.c:155:14: error: redundant redeclaration of '__Static_assert_function' [-Werror=redundant-decls]
+../graphene-1.10.8/src/graphene-gobject.c:155:14: note: previous declaration of '__Static_assert_function' with type 'int (*(void))[1]'
+../graphene-1.10.8/src/graphene-gobject.c:155:14: error: redundant redeclaration of '__Static_assert_function' [-Werror=redundant-decls]
+../graphene-1.10.8/src/graphene-gobject.c:155:14: note: previous declaration of '__Static_assert_function' with type 'int (*(void))[1]'
+
+Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
+Upstream-Status: Pending
+---
+ meson.build | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index fa65177fc1d2..fc11eced11e3 100644
+--- a/meson.build
++++ b/meson.build
+@@ -98,7 +98,6 @@ else
+     '-Wno-unused-local-typedefs',
+     '-Werror=float-conversion',
+     '-Werror=float-equal',
+-    '-Werror=redundant-decls',
+     '-Werror=missing-prototypes',
+     '-Werror=missing-declarations',
+     '-Werror=format=2',
diff --git a/meta/recipes-graphics/graphene/graphene_1.10.8.bb b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
index e2e82b32aa82..eb8adc64f41a 100644
--- a/meta/recipes-graphics/graphene/graphene_1.10.8.bb
+++ b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
@@ -6,7 +6,9 @@  LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=a7d871d9e23c450c421a85bb2819f648"
 
 inherit gnomebase gobject-introspection gtk-doc
 
-SRC_URI += "file://float-div.patch"
+SRC_URI += "file://float-div.patch \
+    file://0001-meson.build-disable-Werror-redundant-decls.patch \
+"
 
 SRC_URI[archive.sha256sum] = "a37bb0e78a419dcbeaa9c7027bcff52f5ec2367c25ec859da31dfde2928f279a"