Message ID | 20250424150148.1749041-1-ross.burton@arm.com |
---|---|
State | New |
Headers | show |
Series | wget: use libpcre2 | expand |
Shouldn't the pcre be explicitly disabled via EXTRA_OECONF? Without that the configure may try to autodetect / search for it... Peter > -----Original Message----- > From: openembedded-core@lists.openembedded.org <openembedded- > core@lists.openembedded.org> On Behalf Of Ross Burton via > lists.openembedded.org > Sent: Thursday, April 24, 2025 17:02 > To: openembedded-core@lists.openembedded.org > Subject: [OE-core] [PATCH] wget: use libpcre2 > > libpcre is obsolete and unmaintained, as wget supports libpcre2 now we > should use that instead. > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta/recipes-extended/wget/wget.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes- > extended/wget/wget.inc > index 151aeabcdce..d2f772e4090 100644 > --- a/meta/recipes-extended/wget/wget.inc > +++ b/meta/recipes-extended/wget/wget.inc > @@ -36,5 +36,5 @@ PACKAGECONFIG[iri] = "--enable-iri,--disable-iri,libidn2" > PACKAGECONFIG[libpsl] = "--with-libpsl,--without-libpsl,libpsl" > PACKAGECONFIG[libuuid] = "--with-libuuid,--without-libuuid,util-linux" > PACKAGECONFIG[openssl] = "--with-ssl=openssl,,openssl" > -PACKAGECONFIG[pcre] = "--enable-pcre,--disable-pcre,libpcre" > +PACKAGECONFIG[pcre] = "--enable-pcre2,--disable-pcre2,libpcre2" > PACKAGECONFIG[zlib] = "--with-zlib,--without-zlib,zlib" > -- > 2.43.0
On Fri, 25 Apr 2025 at 09:15, Peter Marko via lists.openembedded.org <peter.marko=siemens.com@lists.openembedded.org> wrote: > Shouldn't the pcre be explicitly disabled via EXTRA_OECONF? > Without that the configure may try to autodetect / search for it... Yes. Or there should be a new PACKAGECONFIG pcre2 specifically for that implementation, replacing pcre in the default enabled set in the recipe, and pcre definition should stay as it is. Alex
diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc index 151aeabcdce..d2f772e4090 100644 --- a/meta/recipes-extended/wget/wget.inc +++ b/meta/recipes-extended/wget/wget.inc @@ -36,5 +36,5 @@ PACKAGECONFIG[iri] = "--enable-iri,--disable-iri,libidn2" PACKAGECONFIG[libpsl] = "--with-libpsl,--without-libpsl,libpsl" PACKAGECONFIG[libuuid] = "--with-libuuid,--without-libuuid,util-linux" PACKAGECONFIG[openssl] = "--with-ssl=openssl,,openssl" -PACKAGECONFIG[pcre] = "--enable-pcre,--disable-pcre,libpcre" +PACKAGECONFIG[pcre] = "--enable-pcre2,--disable-pcre2,libpcre2" PACKAGECONFIG[zlib] = "--with-zlib,--without-zlib,zlib"
libpcre is obsolete and unmaintained, as wget supports libpcre2 now we should use that instead. Signed-off-by: Ross Burton <ross.burton@arm.com> --- meta/recipes-extended/wget/wget.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)